Fix tests for, compatibility with Drupal 10.2

Fixed most of the errors.
Still have issue during migration test:

    1) Drupal\Tests\metatag\Kernel\Migrate\d7\MetatagEntitiesTest::testMetatag
    Missing bundle entity, entity type node_type, entity id test_content_type.
    (/builds/issue/metatag-3413633/web/core/lib/Drupal/Core/Entity/EntityType.php:891)
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'status'
    +'error'
    
    /builds/issue/metatag-3413633/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
    /builds/issue/metatag-3413633/web/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php:201
    /builds/issue/metatag-3413633/web/core/modules/migrate/src/MigrateExecutable.php:508
    /builds/issue/metatag-3413633/web/core/modules/migrate/src/MigrateExecutable.php:273
    /builds/issue/metatag-3413633/web/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php:177
    /builds/issue/metatag-3413633/web/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php:190
    /builds/issue/metatag-3413633/tests/src/Kernel/Migrate/d7/MetatagEntitiesTest.php:96
    /builds/issue/metatag-3413633/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Made debug and issue happens during import 'd7_metatag_field_instance', and fail happen at EntityConfigBase::import line 145

    if (!$this->isTranslationDestination()) {
      $entity->save();
    }

Not sure how to fix it.

I think tests need to be refactored there are tons of places where setup happens in the test case, instead of setUp method.
And fields can be created directly from code, no need to use UI to create them.

It would be great if someone can help with migrations.

@cmlara give me some advices and I was able to run tests on D9.
Should we fix them?

I'm not worried about running tests against D9 anymore.

You are just in time. Thanks for the feedback. I will disable testing for D9 in MR.

I still have no clue how to fix

Drupal\Tests\metatag\Kernel\Migrate\d7\MetatagEntitiesTest::testMetatag

I believe this is related to the node_type has been replaced by entity_bundle:node. #1932810: Add entity bundles condition plugin for entities with bundles → .

This is critical as it's blocking other issues.

Will put some time to fix it.

No progress so far.

DamienMcKenna → credited Mingsong → .

From Mingsong in 📌 Drupal 10.2.x compatibility Closed: duplicate :

Since Drupal 10.2.0, the FieldStorageConfigEditForm is now rendered as a subform within FieldConfigEditForm.

It is no longer sufficient to rely solely on hook_field_storage_config_update to update the field configuration entity when changes are made to field storage.

Details see the Drupal core change log in
https://www.drupal.org/node/3386675 →

Proposed resolution

Move the logic implemented by metatag_form_field_storage_config_edit_form_alter() at line 76 in metatag.module to metatag_form_field_config_edit_form_alter().

Thanks @Damien,

According to my quick local test.

The cardinality box is still hiding as what it looked like in Drupal 10.1

WIP.

Doh.

The last submitted patch, 16: metatag-n3413633-16.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Will finish this off.

WIP.

fistpump.gif

Committed. Thank you all!

Automatically closed - issue fixed for 2 weeks with no activity.