Make code pass the gitlab pipeline

Created on 30 June 2024, 6 months ago
Updated 1 August 2024, 5 months ago

Problem/Motivation

We recently added the gitlab CI pipeline for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇳🇱Netherlands batigolix Utrecht

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @batigolix
  • Assigned to nexusnovaz
  • 🇬🇧United Kingdom nexusnovaz

    Ill take a look at this!

  • Pipeline finished with Success
    6 months ago
    Total: 140s
    #216961
  • Issue was unassigned.
  • Status changed to Needs work 6 months ago
  • 🇬🇧United Kingdom nexusnovaz

    Made a push to remove two unused use statements which is now passing phpcs which can be reviewed in MR !2. There is an issue with cspell which is erroring with:

    Dictionary Error with (drupal) Error: ENOENT: no such file or directory, open '/builds/issue/link_description_attributes-3458115/web/core/misc/cspell/drupal-dictionary.txt'

    . I'll mark as needs work for that issue.

  • Pipeline finished with Success
    5 months ago
    Total: 1429737s
    #220143
  • First commit to issue fork.
  • Pipeline finished with Success
    5 months ago
    Total: 123s
    #234619
  • Status changed to Needs review 5 months ago
  • 🇳🇱Netherlands arantxio Dordrecht

    @NexusNovaz, your issues with the test where due to a problem with the gitlab templates, this has been fixed now, I've rerun the test and saw that there were 2 words that needed ignoring.

    This should fix the pipeline issues.

  • Status changed to RTBC 5 months ago
  • 🇮🇳India ankitv18

    Marking this one RTBC as changes are quite straightforward and pipelines are executed without any warning.

  • Reviewed and verified that tests are passing in the pipeline.

  • 🇳🇱Netherlands batigolix Utrecht
  • Status changed to Fixed 5 months ago
  • 🇳🇱Netherlands batigolix Utrecht

    Thanks everybody for the contributions.

  • Status changed to RTBC 5 months ago
  • 🇳🇱Netherlands batigolix Utrecht
Production build 0.71.5 2024