MR looks good to me. Passes PHPCS tests. Marking as RTBC.
Nice, thanks for that @avpaderno. I've made those changes and i believe it is all correct. Please can someone review MR !11912
Please review MR !20. Added the .cspell-project-words.txt file and also altered other files where needed
nexusnovaz → made their first commit to this issue’s fork.
I've made the changes needed for phpcs in MR !19. There is one remaining issue which mentions that
use Drupal\Console\Annotations\DrupalCommand;
is an unused use statement in src/Command/ExportDrupalCommand.php. Just wanted to confirm thats good to remove.
I'll take a look at this
I've made the changes in MR !11912 though there I have a question for Line 118. Currently the correct usage in the html tag should be href=":foo", but then @foo is used as the placeholder for the text surrounded by the html tag. However, there is no substitution for this in the array. Should the @foo also be changed to use :foo as it would appear they should have the same output?
nexusnovaz → made their first commit to this issue’s fork.
MR is simple and LGTM
nexusnovaz → created an issue.
nexusnovaz → created an issue.
I've rolled patch #3360268-3: Improve javascript to not need unsafe-eval → to an MR. Please can MR !23 be reviewed
nexusnovaz → changed the visibility of the branch 3360268-improve-javascript-to to hidden.
nexusnovaz → made their first commit to this issue’s fork.
Hi @isa.bel
It seems there is still some more to go. I reccomend using phpcs in your local environment as you go to fix all the issues.
I'm going to attach a file to this (phpcs_output.txt), for ease but you can also see the output below:
FILE: /var/www/html/web/modules/custom/jstimer/jstimer.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 2 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment (Drupal.Commenting.FileComment.Missing)
3 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
3 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; (PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse)
12 | ERROR | [x] Expected 1 blank line before function; 0 found (Squiz.WhiteSpace.FunctionSpacing.Before)
31 | ERROR | [x] Doc comment short description must start with a capital letter (Drupal.Commenting.DocComment.ShortNotCapital)
33 | ERROR | [ ] Missing parameter type (Drupal.Commenting.FunctionComment.MissingParamType)
35 | ERROR | [x] Separate the @param and @return sections by a blank line. (Drupal.Commenting.DocComment.TagGroupSpacing)
36 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters (Drupal.Files.LineLength.TooLong)
38 | ERROR | [x] Incorrect spacing between argument "$format_string" and equals sign; expected 1 but found 0 (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals)
38 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$format_string"; expected 1 but found 0 (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterEquals)
39 | ERROR | [x] Expected 1 space after "="; 6 found (Squiz.WhiteSpace.OperatorSpacing.SpacingAfter)
39 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
40 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
40 | ERROR | [x] There should be no white space before a closing ")" (Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace)
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/jstimer/modules/jst_clock/jst_clock.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 21 ERRORS AND 3 WARNINGS AFFECTING 19 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." (Drupal.Commenting.HookComment.HookCommentFormat)
12 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
18 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
19 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
20 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
21 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
24 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
28 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
32 | ERROR | [ ] The array declaration extends to column 134 (the limit is 120). The array content should be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
32 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
33 | WARNING | [x] A comma should follow the last multiline array item. Found: ) (Drupal.Arrays.Array.CommaLastItem)
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
36 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
37 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
38 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
39 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
40 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
45 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters (Drupal.Files.LineLength.TooLong)
50 | ERROR | [x] Missing function doc comment (Drupal.Commenting.FunctionComment.Missing)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/jstimer/modules/jst_timer/jst_timer.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 52 ERRORS AND 5 WARNINGS AFFECTING 55 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
5 | ERROR | [x] Function comment short description must start with exactly one space (Drupal.Commenting.DocComment.ShortStartSpace)
6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
7 | ERROR | [x] There must be exactly one blank line after the file comment (Drupal.Commenting.FileComment.SpacingAfterComment)
9 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
9 | ERROR | [x] When importing a class with "use", do not include a leading \ (Drupal.Classes.UseLeadingBackslash.SeparatorStart)
12 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." (Drupal.Commenting.HookComment.HookCommentFormat)
13 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
22 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
25 | WARNING | [x] A comma should follow the last multiline array item. Found: 1 (Drupal.Arrays.Array.CommaLastItem)
28 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
33 | ERROR | [x] Array indentation error, expected 4 spaces but found 6 (Drupal.Arrays.Array.ArrayIndentation)
34 | ERROR | [x] Array indentation error, expected 4 spaces but found 6 (Drupal.Arrays.Array.ArrayIndentation)
41 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
42 | ERROR | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
43 | ERROR | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
44 | ERROR | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
45 | ERROR | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
49 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
52 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
58 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
61 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
66 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
74 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
80 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
85 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use '' quotes instead (Drupal.Semantics.FunctionT.BackslashDoubleQuote)
87 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
94 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
99 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
105 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
114 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
120 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
125 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
128 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
135 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
138 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
144 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
150 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
153 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
159 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
168 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters (Drupal.Files.LineLength.TooLong)
172 | ERROR | [x] Missing function doc comment (Drupal.Commenting.FunctionComment.Missing)
200 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
201 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment (Drupal.Commenting.DocComment.SpacingBeforeTags)
201 | ERROR | [ ] Return type missing for @return tag in function comment (Drupal.Commenting.FunctionComment.MissingReturnType)
204 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "translate_replacements" but expected "jst_timer_translate_replacements"
| | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
205 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
213 | ERROR | [x] Expected 1 blank line after function; 2 found (Squiz.WhiteSpace.FunctionSpacing.After)
217 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
218 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
220 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
226 | ERROR | [x] Expected 1 blank line after function; 2 found (Squiz.WhiteSpace.FunctionSpacing.After)
230 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
231 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
253 | ERROR | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
255 | ERROR | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
260 | ERROR | [x] Expected 1 space after "="; 2 found (Squiz.WhiteSpace.OperatorSpacing.SpacingAfter)
285 | ERROR | [x] Expected 1 newline at end of file; 2 found (Drupal.Files.EndFileNewline.TooMany)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 49 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 191ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
------------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
------------------------------------------------------------------------------------------------
/var/www/html/web/modules/custom/jstimer/jstimer.module 12 2
/var/www/html/web/modules/custom/jstimer/modules/jst_clock/jst_clock.module 21 3
/var/www/html/web/modules/custom/jstimer/modules/jst_timer/jst_timer.module 52 5
------------------------------------------------------------------------------------------------
A TOTAL OF 85 ERRORS AND 10 WARNINGS WERE FOUND IN 3 FILES
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX 81 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
-------------------------------------------------------------------------------
SOURCE COUNT
-------------------------------------------------------------------------------
[x] Drupal.Arrays.DisallowLongArraySyntax.Found 31
[x] Drupal.Arrays.Array.ArrayIndentation 13
[x] Drupal.WhiteSpace.ScopeIndent.IncorrectExact 6
[ ] Drupal.Commenting.DocComment.ShortSingleLine 4
[x] Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar 4
[ ] Drupal.Files.LineLength.TooLong 3
[x] Drupal.Arrays.Array.CommaLastItem 2
[x] Drupal.Classes.UnusedUseStatement.UnusedUse 2
[x] Drupal.Commenting.FunctionComment.Missing 2
[ ] Drupal.Commenting.HookComment.HookCommentFormat 2
[x] Squiz.Strings.ConcatenationSpacing.PaddingFound 2
[x] Squiz.WhiteSpace.FunctionSpacing.After 2
[x] Squiz.WhiteSpace.OperatorSpacing.SpacingAfter 2
[x] Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines 2
[ ] Drupal.Arrays.Array.LongLineDeclaration 1
[x] Drupal.Classes.UseLeadingBackslash.SeparatorStart 1
[x] Drupal.Commenting.DocComment.ShortNotCapital 1
[x] Drupal.Commenting.DocComment.ShortStartSpace 1
[x] Drupal.Commenting.DocComment.SpacingBeforeTags 1
[x] Drupal.Commenting.DocComment.TagGroupSpacing 1
[x] Drupal.Commenting.FileComment.Missing 1
[x] Drupal.Commenting.FileComment.SpacingAfterComment 1
[ ] Drupal.Commenting.FunctionComment.MissingParamType 1
[ ] Drupal.Commenting.FunctionComment.MissingReturnType 1
[x] Drupal.Files.EndFileNewline.TooMany 1
[ ] Drupal.NamingConventions.ValidFunctionName.InvalidPrefix 1
[ ] Drupal.Semantics.FunctionT.BackslashDoubleQuote 1
[x] Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace 1
[x] PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse 1
[x] Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterEquals 1
[x] Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals 1
[x] Squiz.WhiteSpace.FunctionSpacing.Before 1
-------------------------------------------------------------------------------
A TOTAL OF 95 SNIFF VIOLATIONS WERE FOUND IN 32 SOURCES
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SOURCES AUTOMATICALLY (81 VIOLATIONS IN TOTAL)
-------------------------------------------------------------------------------
nexusnovaz → created an issue.
nexusnovaz → created an issue.
MR LGTM. Seems like a simple change and it shouldn't in theory affect anything else too much currently.
Hey @charlliequadros, i've made a slight modification as the code is actually JS and not PHP, but it appears to still work. Care to review/test again
The change is simple and LGTM. Seems the error is unrelated through im not able to rerun the job?
I just realised the ticket i mentioned is under the same module. Closing this one as duplicate.
This is a ticket created as a kind of duplicate for https://www.drupal.org/project/documentation/issues/3489514 📌 Suggestion for: (2827301) 3.4. Preparing to Install Active as the documentation page says to open a new ticket on this module and upload the file here.
nexusnovaz → created an issue.
This was a simple one to quickly do. Please review MR !16
I'll take a look at this!
Updated the MR to include the review comments
nexusnovaz → created an issue.
MR !14 is ready for review.
Thanks.
Marking as active now as it is merged
Postponing until 3511227 📌 Move Javascript out of PHP files Active is merged in to not cause conflicts.
nexusnovaz → created an issue.
The code in #3511227 lgtm
Code looks good to me and functions as expected
nexusnovaz → changed the visibility of the branch 3511227-move-javascript-out to hidden.
Hey, please review MR !13. I'm unsure if i need to add more information to the readme or the help page, but this is a good start i believe
nexusnovaz → made their first commit to this issue’s fork.
Working on it
Hey, please review MR !9
nexusnovaz → created an issue.
nexusnovaz → created an issue.
nexusnovaz → created an issue.
nexusnovaz → created an issue.
I've added this and it appears to run. Is causing some issues which ill make as a new ticket. Please review MR !8
nexusnovaz → created an issue.
liampower → credited nexusnovaz → .
liampower → credited nexusnovaz → .
liampower → credited nexusnovaz → .
liampower → credited nexusnovaz → .
liampower → credited nexusnovaz → .
liampower → credited nexusnovaz → .
liampower → credited nexusnovaz → .
liampower → credited nexusnovaz → .
This is ready for review. Please see MR !7
liampower → credited nexusnovaz → .
nexusnovaz → made their first commit to this issue’s fork.
nexusnovaz → made their first commit to this issue’s fork.
nexusnovaz → made their first commit to this issue’s fork.
I believe MR !11339 is ready for review. I also found one more which I believe was also a mistake.
Ill take a quick look at this. Should be quick
I'm having the same issue on this. It appears to only be when an image is added with the centre style. If the image has a caption, the styling works fine. So im wondering if its the figure/article styling.
This code below works:
<figure role="group" class="caption caption-drupal-media align-center">
<article class="media media--type-image media--view-mode-full-width">
<div class="field field--name-field-media-image field--type-image field--label-visually_hidden">
<div class="field__label visually-hidden">Image</div>
<div class="field__item">
<img loading="lazy" src="<A URL>/857-630x200.jpg?itok=Fb7MC4Ym" width="630" height="200" alt="test" class="image-style-full-width">
</div>
</div>
</article>
<figcaption>Caption option</figcaption>
</figure>
This code below does not work:
<article class="align-center media media--type-image media--view-mode-full-width">
<div class="field field--name-field-media-image field--type-image field--label-visually_hidden">
<div class="field__label visually-hidden">Image</div>
<div class="field__item">
<img loading="lazy" src="<A URL>/857-630x200.jpg?itok=Fb7MC4Ym" width="630" height="200" alt="test" class="image-style-full-width">
</div>
</div>
</article>
This is using the Gin 8.x-3.0-rc16 & ckeditor5 11.1.1
Are we going to sort .routing by the route name, or the path?
nexusnovaz → made their first commit to this issue’s fork.
liampower → credited nexusnovaz → .
Running the grep command, there was only 20 functions. I've updated those and pushed my changed. Please can you review MR !10445
Ill take a look at this one
Hey, this is ready for review. Please see MR !10444
Had a little issue with PhpStorm auto formatting, but thats been resolved and the MR should only contain changes made to this now. Please could it be reviewed.
Thanks!
Ill take a look at this
Updated the comment, but i believe tests will need an edit also
I was unsure what was meant by fatal error and couldn't find anything specific for loading exceptions so have gone with a normal \Exception. Please could MR !10260 be reviewed.
Thanks
nexusnovaz → made their first commit to this issue’s fork.
Hey, I've made a start on this.
Hopefully im reading this right and understanding the situation. I would assume this just means that it generates the config as
module_name.entity_id if no config_prefix is passed in. Ill set to review in case its right. Please see MR !10258
nexusnovaz → made their first commit to this issue’s fork.
I was trying to write some tests unfortunately I can't seem to get PhpStorm to work with it. I've rolled #12 into the MR !39. I'm going to keep trying to see if i can get mine to work, but if anyone gets it first, feel free.
nexusnovaz → changed the visibility of the branch 3032084-add-an-option to hidden.
nexusnovaz → made their first commit to this issue’s fork.
Hi,
I believe I got quite a few of them, though its actually rather difficult to tell. For example: "The giftcard storage schema." should this be changed or kept the same? Same with "Access control handler for giftcard transactions.". I'm going to mark as needs review for the words, im unsure why the tests are failing. Something about views page 2 schema. If this isn't the correct workflow please let me know and ill make a note for future.
I also noticed another issue which seems out of scope for this ticket but im unsure how to go about creating a bug/ticket for it. In src/Entity/GitftcardType:76 there is `The the` in a comment.
Thanks
nexusnovaz → made their first commit to this issue’s fork.
Hey,
Thanks for that. I wasn't too sure about the return type but also wasn't sure what the correct answer was. Thanks for the link to the coding standards for this issue too! Setting back to needs review before pipeline has run, but it should be good!
Thanks
Hey, can MR !10040 please be reviewed. Pipelines had a couple of fails, but after a retest they were fine.
Thanks!
I'll take a quick look at this
Hey @joachim,
Apologies, was waiting for the pipeline to pass/fail before changing and requesting code review on this! Could i confirm the workflow process? Is it When i start working on an issue, i assign to myself and leave as active? Or change to needs work?
Also, i believe MR !10007 is ready for review. There was a failed test but that seems unrelated to this issue, so im hoping a rerun of that test will fix it.
Thanks.
nexusnovaz → made their first commit to this issue’s fork.
Hi @c.moisiadis, would you mind assigning credits for this issue.
Thanks.
Another issue with phpstan. has less information than #61
----------------------------------------------------------------------------------------------------
Running PHPStan on changed files.
PHPStan: failed
----------------------------------------------------------------------------------------------------
I am unsure how to fix this
An unrealted test was failing, but after a rerun, its all green now. Marking as needs review unless i've missed something else?