🇬🇧United Kingdom @nexusnovaz

I've added the statement and opened the MR 12755. However, i know this is dependent on 🐛 DefaultLazyPluginCollection::initializePlugin() throws the wrong sort of exception Active , however, im hoping that we can merge that in without any issues once upstream. I won't mark as needs review just yet, but will keep an eye on that parent ticket.

nexusnovaz → made their first commit to this issue’s fork.

Hey @joachim, I suspect @smustgrave was referring to using t() instead of sprintf(). Just in case he didn't mean this, i won't mark as needs work

I think I finally got this all working! I created a new function to separate it all out. Please review!

Yeah, i was struggling with it, coming back to it today. Thanks for noticing that spelling mistake!

I fear as though i have messed up the pulling of 11.x. Though i did make the change to remove the try catch clause and replacing it with a guard clause. Would someone be so kind as to explain what to do in this situation? For example, i did a git pull origin 11.x then git config pull.rebase false once it gave me some warning, then the git pull once again. Sorted the conflict (or so i thought) and pushed.

nexusnovaz → made their first commit to this issue’s fork.

Hey @ankitv18, for my learning, whats the need for those composer changes and the rift.info.yml for implementing ci/cd?

Hey, could you please review MR !100. I've added some text on the constant to mention that it updates the existing alias.

nexusnovaz → made their first commit to this issue’s fork.

PR LGTM, couldn't see any other references to QueryConditionInterface. I also couldn't find any direct replacements for QueryConditionInterface::having()

I was able to get tests working locally and have fixed the issue and the pipeline now passes. Happy to move this back to NR. Please review MR !12710

I'm moving this back to needs work. I'm currently struggling to get tests working locally, so if someone would like to take this on, feel free.

I've created MR !12710. Instead of the format listed, I believed it should be an Oxford comma, though this wouldn't be difficult to replace if not. Please could someone review.

nexusnovaz → made their first commit to this issue’s fork.

I've updated both branches to hopefully pass review bot. Please can we review?

nexusnovaz → made their first commit to this issue’s fork.

Please could you review MR !10. In theory it should also be compatible with 2.x branch.

Thanks

I have just opened 📌 Implement CI/CD for this module Active which i believe would also solve some issues. Requiring the pipeline to be fixed before any branches get merged.

I can take a look at setting this up as it is still useful rather than waiting for the pipeline

nexusnovaz → created an issue.

I've added some descriptions, i think this is good for review.

Thanks.

nexusnovaz → made their first commit to this issue’s fork.

Please could someone review MR !9.

I found a couple of other instances after running cspell where it was using British English spelling (or just a mistake) so i resolved those as well.

Thanks

I'll take a look at this.

I've found and removed the duplicated html elements. Please review MR !21

nexusnovaz → made their first commit to this issue’s fork.

I was also able to replicate this and made a quick patch. Will turn this into a PR shortly. Hopefully I have understood the issue and fixed it according to what others need.

My votes:

- Will Huggins (zoocha-will)
- Marine Gandy (Mupsi)

I resolved the issue that the review bot raised however there is the nightwatch test failing. Unsure if its just glitching and a rerun is fine, or if its because we're behind on commits?

nexusnovaz → made their first commit to this issue’s fork.

MR looks good to me. Passes PHPCS tests. Marking as RTBC.

Nice, thanks for that @avpaderno. I've made those changes and i believe it is all correct. Please can someone review MR !11912

Please review MR !20. Added the .cspell-project-words.txt file and also altered other files where needed

nexusnovaz → made their first commit to this issue’s fork.

I've made the changes needed for phpcs in MR !19. There is one remaining issue which mentions that

use Drupal\Console\Annotations\DrupalCommand;

is an unused use statement in src/Command/ExportDrupalCommand.php. Just wanted to confirm thats good to remove.

I'll take a look at this

I've made the changes in MR !11912 though there I have a question for Line 118. Currently the correct usage in the html tag should be href=":foo", but then @foo is used as the placeholder for the text surrounded by the html tag. However, there is no substitution for this in the array. Should the @foo also be changed to use :foo as it would appear they should have the same output?

nexusnovaz → made their first commit to this issue’s fork.

MR is simple and LGTM

nexusnovaz → created an issue.

nexusnovaz → created an issue.

I've rolled patch #3360268-3: Improve javascript to not need unsafe-eval → to an MR. Please can MR !23 be reviewed

nexusnovaz → changed the visibility of the branch 3360268-improve-javascript-to to hidden.

nexusnovaz → made their first commit to this issue’s fork.

Hi @isa.bel

It seems there is still some more to go. I reccomend using phpcs in your local environment as you go to fix all the issues.

I'm going to attach a file to this (phpcs_output.txt), for ease but you can also see the output below:

FILE: /var/www/html/web/modules/custom/jstimer/jstimer.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 2 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment (Drupal.Commenting.FileComment.Missing)
  3 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
  3 | ERROR   | [x] There must be one blank line after the last USE statement; 0 found; (PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse)
 12 | ERROR   | [x] Expected 1 blank line before function; 0 found (Squiz.WhiteSpace.FunctionSpacing.Before)
 31 | ERROR   | [x] Doc comment short description must start with a capital letter (Drupal.Commenting.DocComment.ShortNotCapital)
 33 | ERROR   | [ ] Missing parameter type (Drupal.Commenting.FunctionComment.MissingParamType)
 35 | ERROR   | [x] Separate the @param and @return sections by a blank line. (Drupal.Commenting.DocComment.TagGroupSpacing)
 36 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters (Drupal.Files.LineLength.TooLong)
 38 | ERROR   | [x] Incorrect spacing between argument "$format_string" and equals sign; expected 1 but found 0 (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals)
 38 | ERROR   | [x] Incorrect spacing between default value and equals sign for argument "$format_string"; expected 1 but found 0 (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterEquals)
 39 | ERROR   | [x] Expected 1 space after "="; 6 found (Squiz.WhiteSpace.OperatorSpacing.SpacingAfter)
 39 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 40 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 40 | ERROR   | [x] There should be no white space before a closing ")" (Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace)
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/jstimer/modules/jst_clock/jst_clock.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 21 ERRORS AND 3 WARNINGS AFFECTING 19 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." (Drupal.Commenting.HookComment.HookCommentFormat)
 12 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
 16 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
 18 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
 18 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 19 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
 20 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
 21 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
 24 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
 24 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
 28 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 32 | ERROR   | [ ] The array declaration extends to column 134 (the limit is 120). The array content should be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
 32 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 33 | WARNING | [x] A comma should follow the last multiline array item. Found: ) (Drupal.Arrays.Array.CommaLastItem)
 36 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
 36 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 37 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
 38 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
 39 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
 40 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8 (Drupal.Arrays.Array.ArrayIndentation)
 43 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
 45 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters (Drupal.Files.LineLength.TooLong)
 50 | ERROR   | [x] Missing function doc comment (Drupal.Commenting.FunctionComment.Missing)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/jstimer/modules/jst_timer/jst_timer.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 52 ERRORS AND 5 WARNINGS AFFECTING 55 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   5 | ERROR   | [x] Function comment short description must start with exactly one space (Drupal.Commenting.DocComment.ShortStartSpace)
   6 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
   7 | ERROR   | [x] There must be exactly one blank line after the file comment (Drupal.Commenting.FileComment.SpacingAfterComment)
   9 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
   9 | ERROR   | [x] When importing a class with "use", do not include a leading \ (Drupal.Classes.UseLeadingBackslash.SeparatorStart)
  12 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for        
     |         |     xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." (Drupal.Commenting.HookComment.HookCommentFormat)
  13 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
  22 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  25 | WARNING | [x] A comma should follow the last multiline array item. Found: 1 (Drupal.Arrays.Array.CommaLastItem)
  28 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  33 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6 (Drupal.Arrays.Array.ArrayIndentation)
  34 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6 (Drupal.Arrays.Array.ArrayIndentation)
  41 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  42 | ERROR   | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
  43 | ERROR   | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
  44 | ERROR   | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
  45 | ERROR   | [x] Array indentation error, expected 8 spaces but found 9 (Drupal.Arrays.Array.ArrayIndentation)
  49 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  52 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  58 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  61 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  66 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  74 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  80 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  85 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use '' quotes instead (Drupal.Semantics.FunctionT.BackslashDoubleQuote)
  87 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  94 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
  99 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 105 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 114 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 120 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 125 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 128 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 135 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
 138 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 144 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 150 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
 153 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 159 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 168 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters (Drupal.Files.LineLength.TooLong)
 172 | ERROR   | [x] Missing function doc comment (Drupal.Commenting.FunctionComment.Missing)
 200 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
 201 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment (Drupal.Commenting.DocComment.SpacingBeforeTags)
 201 | ERROR   | [ ] Return type missing for @return tag in function comment (Drupal.Commenting.FunctionComment.MissingReturnType)
 204 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "translate_replacements" but expected "jst_timer_translate_replacements"
     |         |     (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
 205 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 213 | ERROR   | [x] Expected 1 blank line after function; 2 found (Squiz.WhiteSpace.FunctionSpacing.After)
 217 | ERROR   | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
 218 | ERROR   | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
 220 | ERROR   | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
 226 | ERROR   | [x] Expected 1 blank line after function; 2 found (Squiz.WhiteSpace.FunctionSpacing.After)
 230 | ERROR   | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
 231 | ERROR   | [x] Expected 1 space(s) before asterisk; 2 found (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
 253 | ERROR   | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
 255 | ERROR   | [x] Concat operator must be surrounded by a single space (Squiz.Strings.ConcatenationSpacing.PaddingFound)
 260 | ERROR   | [x] Expected 1 space after "="; 2 found (Squiz.WhiteSpace.OperatorSpacing.SpacingAfter)
 285 | ERROR   | [x] Expected 1 newline at end of file; 2 found (Drupal.Files.EndFileNewline.TooMany)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 49 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 191ms; Memory: 6MB


PHP CODE SNIFFER REPORT SUMMARY
------------------------------------------------------------------------------------------------
FILE                                                                            ERRORS  WARNINGS
------------------------------------------------------------------------------------------------
/var/www/html/web/modules/custom/jstimer/jstimer.module                         12      2
/var/www/html/web/modules/custom/jstimer/modules/jst_clock/jst_clock.module     21      3
/var/www/html/web/modules/custom/jstimer/modules/jst_timer/jst_timer.module     52      5
------------------------------------------------------------------------------------------------
A TOTAL OF 85 ERRORS AND 10 WARNINGS WERE FOUND IN 3 FILES
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX 81 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
-------------------------------------------------------------------------------
    SOURCE                                                                COUNT
-------------------------------------------------------------------------------
[x] Drupal.Arrays.DisallowLongArraySyntax.Found                           31
[x] Drupal.Arrays.Array.ArrayIndentation                                  13
[x] Drupal.WhiteSpace.ScopeIndent.IncorrectExact                          6
[ ] Drupal.Commenting.DocComment.ShortSingleLine                          4
[x] Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar                 4
[ ] Drupal.Files.LineLength.TooLong                                       3
[x] Drupal.Arrays.Array.CommaLastItem                                     2
[x] Drupal.Classes.UnusedUseStatement.UnusedUse                           2
[x] Drupal.Commenting.FunctionComment.Missing                             2
[ ] Drupal.Commenting.HookComment.HookCommentFormat                       2
[x] Squiz.Strings.ConcatenationSpacing.PaddingFound                       2
[x] Squiz.WhiteSpace.FunctionSpacing.After                                2
[x] Squiz.WhiteSpace.OperatorSpacing.SpacingAfter                         2
[x] Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines                     2
[ ] Drupal.Arrays.Array.LongLineDeclaration                               1
[x] Drupal.Classes.UseLeadingBackslash.SeparatorStart                     1
[x] Drupal.Commenting.DocComment.ShortNotCapital                          1
[x] Drupal.Commenting.DocComment.ShortStartSpace                          1
[x] Drupal.Commenting.DocComment.SpacingBeforeTags                        1
[x] Drupal.Commenting.DocComment.TagGroupSpacing                          1
[x] Drupal.Commenting.FileComment.Missing                                 1
[x] Drupal.Commenting.FileComment.SpacingAfterComment                     1
[ ] Drupal.Commenting.FunctionComment.MissingParamType                    1
[ ] Drupal.Commenting.FunctionComment.MissingReturnType                   1
[x] Drupal.Files.EndFileNewline.TooMany                                   1
[ ] Drupal.NamingConventions.ValidFunctionName.InvalidPrefix              1
[ ] Drupal.Semantics.FunctionT.BackslashDoubleQuote                       1
[x] Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace               1
[x] PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse                      1
[x] Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterEquals   1
[x] Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals  1
[x] Squiz.WhiteSpace.FunctionSpacing.Before                               1
-------------------------------------------------------------------------------
A TOTAL OF 95 SNIFF VIOLATIONS WERE FOUND IN 32 SOURCES
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SOURCES AUTOMATICALLY (81 VIOLATIONS IN TOTAL)
-------------------------------------------------------------------------------

nexusnovaz → created an issue.

nexusnovaz → created an issue.

MR LGTM. Seems like a simple change and it shouldn't in theory affect anything else too much currently.

Hey @charlliequadros, i've made a slight modification as the code is actually JS and not PHP, but it appears to still work. Care to review/test again

The change is simple and LGTM. Seems the error is unrelated through im not able to rerun the job?

I just realised the ticket i mentioned is under the same module. Closing this one as duplicate.

This is a ticket created as a kind of duplicate for https://www.drupal.org/project/documentation/issues/3489514 📌 Suggestion for: (2827301) 3.4. Preparing to Install Active as the documentation page says to open a new ticket on this module and upload the file here.

nexusnovaz → created an issue.

This was a simple one to quickly do. Please review MR !16

I'll take a look at this!

Updated the MR to include the review comments

nexusnovaz → created an issue.

MR !14 is ready for review.

Thanks.

Marking as active now as it is merged

Postponing until 3511227 📌 Move Javascript out of PHP files Active is merged in to not cause conflicts.

nexusnovaz → created an issue.

The code in #3511227 lgtm

Code looks good to me and functions as expected

nexusnovaz → changed the visibility of the branch 3511227-move-javascript-out to hidden.

Hey, please review MR !13. I'm unsure if i need to add more information to the readme or the help page, but this is a good start i believe

nexusnovaz → made their first commit to this issue’s fork.

Working on it

Hey, please review MR !9

nexusnovaz → created an issue.

nexusnovaz → created an issue.

nexusnovaz → created an issue.

nexusnovaz → created an issue.

I've added this and it appears to run. Is causing some issues which ill make as a new ticket. Please review MR !8

nexusnovaz → created an issue.

liampower → credited nexusnovaz → .

liampower → credited nexusnovaz → .

liampower → credited nexusnovaz → .

liampower → credited nexusnovaz → .

liampower → credited nexusnovaz → .

liampower → credited nexusnovaz → .

liampower → credited nexusnovaz → .

liampower → credited nexusnovaz → .

This is ready for review. Please see MR !7

liampower → credited nexusnovaz → .

nexusnovaz → made their first commit to this issue’s fork.

nexusnovaz → made their first commit to this issue’s fork.

nexusnovaz → made their first commit to this issue’s fork.

I believe MR !11339 is ready for review. I also found one more which I believe was also a mistake.