Mandatory Asterisk is not rendered for the Nested field groups

I see we would need to add something like this within - formatters/fieldset/fieldset.js

$('.fieldset__label').first().addClass('form-required');

I've added the line you mentioned above to the file. Tested on a vanilla drupal 10 instance and the first fieldset is marked as required. Though, i suspect another change may be needed to require the second fieldset.

Apologies!

Updated the location and the line of code. I believe it now works as expected. Please could !55 this be reviewed

this issue affects some themes, eg Claro or Olivero

MR!55 fixes the issue - tested on D 10.2.7 on Claro and Olivero.

before

after

Why do tests fail?

@Edde20

what's in the #8 patch?
does the issue require re-testing?
please set status of the issue to "needs review" and add some description to what's in the patch.

Hi, I have verified this issue, on the D11 version. This is working fine for me.

Testing steps:
1. Edit Article content type
2. Navigate to manage form display
3. Add nested field groups, move one mandatory field within the nested group
4. Add/Edit the article content
5. Mandatory Asterisk will be missing for Nested field groups

Testing Results:
Applied the patch successfully and aesterisk sign also working fine set as required fields.

Attaching screeenshots.

Thanks

Hi, I’ve reviewed the merge request from comment #13, and it works for me.

I’ve attached screenshots showing the before and after of checking the branch from the merge request in comment #13.

Before

After

Thanks

@anybody I noticed that you set this issue to version 4.x-dev but the MR merges into 8.x-3.x. I'm looking to solve this issue in 4.x. Does the MR need to be rewritten for 4.x-dev?

This issue now contains a couple related/duplicate fixes: https://www.drupal.org/project/field_group/issues/3160987 🐛 Form Required Class Missing from Claro RTBC

• Resolves missing asterisk for a Tab field group nested inside a Details field group (the Tab is technically a <details> element and there is nothing preventing a user from doing this).
• If the theme is Claro, fixes missing asterisk on <fieldset> by adding .form-required class to .fieldset__label inside the <legend>.

I don't believe the patch we have in this issue is really related to nested field groups. Required asterisks are missing from all <fieldset> in Claro without this patch or the one from the issue I linked, not just nested ones.

Hi,

I have verified this issue, on the D11 version. This is working fine for me.

Testing steps:

1. Edit Article content type
2. Navigate to manage form display
3. Add nested field groups, move one mandatory field within the nested group
4. Add/Edit the article content
5. Mandatory Asterisk will be missing for Nested field groups

Testing Results:

• Applied the patch successfully, Asterisk mark is showing properly for the Nested field group.

Hence this can be moved to RTBC +1

Attaching screeenshots for reference.