- π³πΏNew Zealand quietone
This is still valid and is suitable for a first issue.
- π©πͺGermany ro-no-lo
With the latest PHP 8.x I think we could avoid many of these phpDocs by just using the types inside the method signature.
- First commit to issue fork.
- πΊπΈUnited States jcorrao
jcorrao β changed the visibility of the branch 1965508-improve-doc-block to hidden.
- Merge request !7990Issue #1965508: Improve documentation for Unicode::truncate() β (Open) created by jcorrao
- Status changed to Needs review
8 months ago 10:45pm 8 May 2024 - πΊπΈUnited States jcorrao
I have gone through and reviewed the patch file from #1 and ported the changes to the relevant counterpart in the 11.x codebase.
The type declarations in the PHPDoc patch were present in 11.x already, however they were missing the `(optional)` declaration as described in the linked PHP Documentation Standards page: http://drupal.org/node/1354
MR !7990 is published and ready for review.
- πΊπΈUnited States smustgrave
So re-ran the tests but getting many failures and not sure why with just comments.
- Status changed to Needs work
8 months ago 12:27pm 10 May 2024 - πΊπΈUnited States smustgrave
Believe the issue has been fixed but just needs a rebase.