- Issue created by @aaron.ferris
- 🇬🇧United Kingdom nexusnovaz
I've made the changes needed for phpcs in MR !19. There is one remaining issue which mentions that
use Drupal\Console\Annotations\DrupalCommand;
is an unused use statement in src/Command/ExportDrupalCommand.php. Just wanted to confirm thats good to remove.
- 🇬🇧United Kingdom aaron.ferris
I think removing the unused 'use' is OK.
Testing this change, im seeing in an issue on the settings form
Fatal error: Class Drupal\search_api_synonym\Plugin\search_api_synonym\export\Solr contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Drupal\Core\Plugin\PluginFormInterface::submitConfigurationForm) in /var/www/html/web/modules/contrib/search_api_synonym/src/Plugin/search_api_synonym/export/Solr.php on line 17
- 🇬🇧United Kingdom aaron.ferris
The changes seem OK, ive pushed a change to reintroduce the failing method, settings form works correctly, I can add and export synonyms as expected
# # Synonyms file for Apache Solr generated by Search API Synonym. # See file https://www.drupal.org/project/search_api_synonym. # another synonym, synonym synonym, test