- First commit to issue fork.
- π¬π§United Kingdom nexusnovaz
This is ready for review. Please see MR !7
- π§π·Brazil charlliequadros
Hi @nexusnovaz
The code seems to work.
It's possible to do something similar, which might be more optimized, but it could also be harder to understand.$am_pm = $hr < 12 ? "am" : "pm"; $hr = $hr % 12 ?: 12;
So, this approach might be the best option.
- π¬π§United Kingdom nexusnovaz
Hey @charlliequadros, i've made a slight modification as the code is actually JS and not PHP, but it appears to still work. Care to review/test again
- π¬π§United Kingdom aaron.ferris
Pulled this down and tested it, seems to work as expected. Previous code had am in a 12 clock format, at 12:58am
With the new change, this shows as 12:58pm.
Screenshots attached
Thanks all.
-
aaron.ferris β
committed 1956eb27 on 2.0.x authored by
nexusnovaz β
Issue #3220837: Updated 12 hour clock logic
-
aaron.ferris β
committed 1956eb27 on 2.0.x authored by
nexusnovaz β