- Issue created by @wombatbuddy
- 🇸🇰Slovakia poker10
This seems to be caused by changes from 📌 Improve FormattableMarkup documentation Fixed . Tagging as novice.
- First commit to issue fork.
- Merge request !11912Issue #3498468: Fix placeholder syntax in FormattableMarkup for consistency → (Closed) created by nexusnovaz
- 🇬🇧United Kingdom nexusnovaz
I've made the changes in MR !11912 though there I have a question for Line 118. Currently the correct usage in the html tag should be
href=":foo"
, but then@foo
is used as the placeholder for the text surrounded by the html tag. However, there is no substitution for this in the array. Should the@foo
also be changed to use:foo
as it would appear they should have the same output? - 🇮🇹Italy apaderno Brescia, 🇮🇹
In
'<a href=":foo">@foo</a>
,@foo
can either be left, or replaced. (I would rather replace it.)Also, in
$this->placeholderFormat('<a href=":foo">@foo</a>, ['@foo' => $some_variable]);
a string delimiter is missing. - 🇬🇧United Kingdom nexusnovaz
Nice, thanks for that @avpaderno. I've made those changes and i believe it is all correct. Please can someone review MR !11912
- 🇳🇿New Zealand quietone
@poker10, thanks for searching for where this was introduced. That is always helpful.
Updated credit. I will commit this presently.
-
quietone →
committed 88f4168d on 11.1.x
Issue #3498468 by nexusnovaz, avpaderno, wombatbuddy, poker10: The...
-
quietone →
committed 88f4168d on 11.1.x
-
quietone →
committed 7caa7cbd on 11.x
Issue #3498468 by nexusnovaz, avpaderno, wombatbuddy, poker10: The...
-
quietone →
committed 7caa7cbd on 11.x