- Issue created by @joachim
- First commit to issue fork.
- Merge request !7143Resolve #3422895: Document creation of new config override object if none exist → (Open) created by jackwrfuller
Modified both function's docs to specify that if there is no config override for the specified language code, a new one is instantiated.
- Status changed to Needs review
about 1 year ago 1:12am 22 March 2024 - Status changed to Needs work
about 1 year ago 2:05pm 22 March 2024 - 🇺🇸United States smustgrave
Thanks for working on this!
Left a comment on the MR. Since the comment is related to the langCode, description should go under that variable.
- Status changed to Needs review
about 2 months ago 1:53am 12 March 2025 - 🇧🇷Brazil charlliequadros
Is anything else needed for this issue?
I'd be happy to work on it if necessary! - 🇩🇪Germany Peter Majmesku 🇩🇪Düsseldorf
peter majmesku → made their first commit to this issue’s fork.
- Merge request !11878Drupal 3422895 3422895 configurablelanguagemanagerinterfacegetlanguageconfigoverride and languageconfigfactoryoverrideinterfacegetoverride → (Open) created by Peter Majmesku
- 🇩🇪Germany Peter Majmesku 🇩🇪Düsseldorf
Looks fine. I fixed spelling. Improved the explanation and line breaks. Can this small change could be merged, please?
- 🇺🇸United States smustgrave
There was already a working MR can we use that one please
Also it was in NW for an issue summary update which is still needed
Thanks
- 🇩🇪Germany Peter Majmesku 🇩🇪Düsseldorf
I could not push into the existing MR. Even with requested push access. What do you mean with issue summary?
- 🇬🇧United Kingdom joachim
I think what I originally wrote for this issue is unclear.
What I was trying to say was that one of the following happen:
1. There is config data already: a LanguageConfigOverride object is created, which holds this data
2. There is no config data: a LanguageConfigOverride is created anyway, which is empty.So it's not so much that 'if there's no data, an object is created', rather 'an object is always created; if there's no data it will be empty'
public function getOverride($langcode, $name) { $storage = $this->getStorage($langcode); $data = $storage->read($name); $override = new LanguageConfigOverride( $name, $storage, $this->typedConfigManager, $this->eventDispatcher ); if (!empty($data)) { $override->initWithData($data); } return $override; }
- 🇧🇷Brazil charlliequadros
Hi Everyone
I’ve improved the comment as joachim suggested.
Could someone please review this MR and let me know if anything else needs to be done?
I made changes in both MRs, but I’m not sure which one is the correct one to merge when it's ready.