ConfigurableLanguageManagerInterface::getLanguageConfigOverride() and LanguageConfigFactoryOverrideInterface::getOverride() should document that they return a new config object if none exists

Created on 21 February 2024, 9 months ago

Updated 22 March 2024, 8 months ago

Problem/Motivation

Both of these methods (one calls the other) should document that if there is no config overide for the requested $langcode, a new config override object is instantiated.

AFAICT from the code, it's not saved at this point.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Documentation →

Last updated about 10 hours ago

No maintainer

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.

Novice
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

DrupalSouth 2024

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Merge Requests

!7143ConfigurableLanguageManagerInterface::getLanguageConfigOverride() and LanguageConfigFactoryOverrideInterface::getOverride() should document that they return a new config object if none exists
Open
jackwrfuller
updated 8 months ago

Comments & Activities

Issue created by @joachim
First commit to issue fork.
Merge request !7143Resolve #3422895: Document creation of new config override object if none exist → (Open) created by jackwrfuller
Comment 8 months ago →
jackwrfuller
Modified both function's docs to specify that if there is no config override for the specified language code, a new one is instantiated.
Status changed to Needs review 8 months ago1:12am 22 March 2024
Comment 8 months ago →
jackwrfuller
Pipeline finished with Success
8 months ago
Total: 464s
#125748
Status changed to Needs work 8 months ago2:05pm 22 March 2024
Comment 8 months ago →
🇺🇸United States smustgrave
Thanks for working on this!

Left a comment on the MR. Since the comment is related to the langCode, description should go under that variable.
Pipeline finished with Success
8 months ago
Total: 499s
#127913

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024