Seems good to me.
Personally, I use markdown a lot for other stuff, and I found it quite jarring that I couldn't use footnotes out of the box (hence why I made the MR). I'm not fussed whether its enabled by default or not though.
In terms of keeping the module easy to use, how about keeping the additional extensions hidden behind an "advanced" section in the settings form?
@wim-leers check out my MR, I've added optional footnote support.
I agree with you that we should allow the user to access CommonMark's additional extensions. As I've done it with the footnotes, it would be easy to add.
It would also be good for markdown_easy to allow you to configure CommonMark's settings. For example, changing the default footnote hrefs (which I had to do because drupal breaks the footnote linking, since it filters out id's with colons in them).
jackwrfuller → created an issue.
jackwrfuller → changed the visibility of the branch 3494117-add-tracker-configuration to hidden.
jackwrfuller → changed the visibility of the branch 3494117-add-tracker-configurations to hidden.
jackwrfuller → created an issue.
A beta release is fine for now I think.
jackwrfuller → created an issue.
@pivica I've had a quick test locally, and the MR version LGTM.
@eojthebrave it doesn't seem like much extra work to add the BC layer, so I added it.
@pivica I have addressed your comments.
I agree, I think a 2.x branch would be good here.
jackwrfuller → created an issue.
I have been made aware of this change record: https://www.drupal.org/node/3375748 → , so it looks that I was right, and the change I made is the correct one to comply with the new API.
I have encountered this issue as well, but in my case it was with the Prism module: https://www.drupal.org/project/prism/issues/3491768 🐛 Prism causes WSOD on field creation for all field types Active
In my case, I think the problem was caused by setting 'category' to a Translation in the FieldType definition.
jackwrfuller → created an issue.
I can confirm this patch works for me. Are we able to get this included in a new release?
pandaski → credited jackwrfuller → .
Comment has been removed.
jackwrfuller → made their first commit to this issue’s fork.
jackwrfuller → made their first commit to this issue’s fork.
Modified both function's docs to specify that if there is no config override for the specified language code, a new one is instantiated.
jackwrfuller → made their first commit to this issue’s fork.
Changed DraggableListBuilderTrait's PHPDoc to:
/**
* Provides a trait for draggable listings of entities.
*
* Classes using this trait must implement \Drupal\Core\Form\FormInterface are expected to set
* the $formBuilder property in their constructor.
*/
jackwrfuller → made their first commit to this issue’s fork.