- Issue created by @joachim
- First commit to issue fork.
- Merge request !7138Resolve #3425849: Document need for classes using DraggableListBuilderTrait to implement FormInterface β (Open) created by jackwrfuller
Changed DraggableListBuilderTrait's PHPDoc to:
/** * Provides a trait for draggable listings of entities. * * Classes using this trait must implement \Drupal\Core\Form\FormInterface are expected to set * the $formBuilder property in their constructor. */
- Status changed to Needs review
8 months ago 12:38am 22 March 2024 - Status changed to RTBC
8 months ago 2:08pm 22 March 2024 - πΊπΈUnited States smustgrave
Appears straightforward. Maintains original info and mentions FormInterface
- π¬π§United Kingdom alexpott πͺπΊπ
Committed f0007c0 and pushed to 10.3.x. Thanks!
Committed 28881d6 and pushed to 11.x. Thanks!diff --git a/core/lib/Drupal/Core/Entity/DraggableListBuilderTrait.php b/core/lib/Drupal/Core/Entity/DraggableListBuilderTrait.php index 2d67e2f4b0..472f774a75 100644 --- a/core/lib/Drupal/Core/Entity/DraggableListBuilderTrait.php +++ b/core/lib/Drupal/Core/Entity/DraggableListBuilderTrait.php @@ -7,8 +7,8 @@ /** * Provides a trait for draggable listings of entities. * - * Classes using this trait must implement \Drupal\Core\Form\FormInterface and are expected to set - * the $formBuilder property in their constructor. + * Classes using this trait must implement \Drupal\Core\Form\FormInterface and + * are expected to set the $formBuilder property in their constructor. */ trait DraggableListBuilderTrait {
Fixed width on commit. Comments are supposed to stay within the 80 character limit.
-
alexpott β
committed f0007c07 on 10.3.x
Issue #3425849 by jackwrfuller, joachim: DraggableListBuilderTrait needs...
-
alexpott β
committed f0007c07 on 10.3.x
- Status changed to Fixed
8 months ago 8:56am 25 March 2024 -
alexpott β
committed 28881d63 on 11.x
Issue #3425849 by jackwrfuller, joachim: DraggableListBuilderTrait needs...
-
alexpott β
committed 28881d63 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.