- Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This is a major (or perhaps even critical) issue as it prevents you from using the functionality.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Created an MR and changed the logic a bit to make it simpler to understand.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
I've reworked the logic during testing.
Test 1
- Go to /admin/people/custom-permissions/list
- Click "Add permission"
- Click "Save"
- Result: no fatal error
Test 2
- Go to /admin/people/custom-permissions/list
- Click "Add permission"
- Duplicate an existing entry, e.g. "Administer account settings 2" and "entity.user.admin_form"
- Click "Save"
- Result: no fatal error
- Delete the original entry name and route
- Click "Save"
- Result: no fatal error
Test 3
- Go to /admin/people/custom-permissions/list
- Click "Add permission"
- Fill in a name but no route
- Click "Save"
- Result: shows error about missing as expected
- Fill in an invalid route but no name
- Result: shows error about missing name as expected
- Fill in an invalid route and a name
- Result: shows error about invalid route as expected
- Fill in an valid route and a name
- Result: saved as expected
- Click Delete link for new entry
- Result: deletes as expected
@kirsten-pol your three tests pass on a default GovCMS installation (drupal 10.3).
However, the issue originally reported by @klonos is still present for me, though I'm not actually sure its a bug. If the route dblog.overview is not present, yes you are prevented from editing or saving the custom permissions - but this is remedied (at least for me) by removing this route. This seems reasonable to me.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks.
Maybe we need a clearer error message in that case?