"Show Row Weights" button cannot be clicked

vasantha deepika → changed the visibility of the branch 3495320-show-row-weights to hidden.

1. I have fixed the toggle issue for the 'Show row weights' functionality.
2. Regarding the icon and font weight changes, I investigated further, and these are not theme-based issues. I verified this behavior in the Claro theme, and the same issue persists there.

Please let me know if any additional adjustments are needed or if you'd like me to investigate further.

jurgenhaas → changed the visibility of the branch 3495320-show-row-weights to active.

Thanks @vasantha deepika for your contribution. I guess you changed the visibility of the MR to hidden accidentally, see #4. I've made it visible again, assuming that it is the code that you'd like to get reviewed.

The MR does resolve the issue partially, only. It allows clicking the button, but the visual part is still not as expected. When loading the page, only the text "Show row weights" is shown, but it's not bold and the icon is missing as well.

The HTML after a page load for that button looks like this:

<button type="button" class="link tabledrag-toggle-weight" data-drupal-selector="tabledrag-toggle-weight">Show row weights</button>

When clicking on it twice, then the markup looks like this:

<button type="button" class="link tabledrag-toggle-weight" data-drupal-selector="tabledrag-toggle-weight">
  <span class="action-link action-link--extrasmall tabledrag-toggle-weight action-link--icon-show">Show row weights</span>
</button>

The difference is that the second (and correct) markup has a span-wrapper around the text. The first one doesn't. We need to find out, why that wrapper is missing after a page load, that should then resolve issue completely.

Thank you for making the merge request visible again and for the detailed feedback!
I will investigate further to determine why the wrapper is not applied after the page loads and work on a fix to address this behavior completely.

@jurgenhaas I have fixed the issue with the missing span wrapper and the visual inconsistencies on the initial page load. The span wrapper now applies correctly, ensuring the button appears as expected with the bold text and icon after the page loads.

For reference, I have attached a video demonstrating the resolved behaviour.
Please review the updated merge request (MR ID: #558) and let me know if there are any further adjustments needed.

Thanks!

This looks nice and I can confirm, it now works as expected.

Even more so, the first attempt is no longer required and you can revert the first 2 changes. Just enhancing the javascript for toggleButtonContent seems to be sufficient.

Thank you for confirming that the fix works as expected and for the suggestion regarding the initial changes.

Based on your feedback, I have reverted the first two changes and updated the merge request (MR ID: #558).

Thanks!

Great work @vasantha deepika, this is working and tests are green as well. Leaving this for @saschaeggi for a final look.

We are using Gin Admin theme, and can confirm this works great!

This is great, fixes the issue. Thanks for the work!

Left one question in the code, moving this back to needs work for now

hi @saschaeggi,
Based on your feedback, I have updated the merge request (MR ID: #558).

Thanks!

Tested. fixes the issue. thanks!

Thanks for the changes Vasantha 👏

Thanks everyone!

Included in the 4.0.4 release: https://www.drupal.org/project/gin/releases/4.0.4 →

Hi, we have updated to 4.04 but despite multiple cache clears at various levels, the 'Show show row weights' button is still not clickable.

Same issue: 'Show show row weights' button is still not clickable.

And fields is not disabled, I changed to claro admin theme and all working.

Gracias

Although #23 says included in the 4.0.4 release, this has only been applied to the 8.x-3.x branch. Patch for 4.x branch attached.

Seems we haven't cherry-picked the commit, my bad 😅

Can you check if it's fixed on 4.0.x-dev?

If so I'll quickly do a 4.0.5 release

Thanks!

Verified fixed on 4.0.x-dev. Thanks for the quick turn around, and for the great(est?) admin theme.

Released 4.0.5 -> https://www.drupal.org/project/gin/releases/4.0.5 →

Automatically closed - issue fixed for 2 weeks with no activity.