🇪🇸Spain @ady1503

Same issue: 'Show show row weights' button is still not clickable.

And fields is not disabled, I changed to claro admin theme and all working.

Gracias

The same thing happens to me. I have left it at version 7.0.4:

"After this commit am no loner able to collapse slider widget in the views exposed form.

It seems to change from details element to fieldset, and I cannot see how to alter this."

Downgrading to 7.0.4 is simplest fix for me

Gracias

I have little time now, the next option is to also transform the "View PDF" link into a button in the nodes.

It would be necessary to add this option in the module configuration form to be able to alter the link label per button with a CSS format.

When I have it I'm going to share it in case it works for someone.

If anyone wants to help, I say thank you in advance.

Thank you.

ady1503 → created an issue.

ady1503 → created an issue.

Hello.

With the last two changes everything is correct.

Thank you.

ady1503 → created an issue.

Hello.

Your modifications working only in page itself, but in views preview not, is the same, check the picture.

I applied an tested in front page and views pages and working well, in views preview not.

Gracias.

ady1503 → created an issue.

ady1503 → created an issue.

Please add new file for version 2.0.0, I not have the rights to do this, at https://localize.drupal.org .

Gracias

Hello.

I have detected that if the option to combine CSS and JS is disabled in the Drupal performance settings, the menus work correctly.

I hope to help find the bug.

Gracias

ady1503 → created an issue.

Hello.

Your patch works, I found that when applying the patch in automatic mode, the changes in the file:
footable.libraries.yml are not applied correctly.
I have made the changes to this file manually and everything works fine.

Gracias.

Hello.

I have applied the patch and there is no change.

It does not act on the alter of the Gin theme.

And yes, I delete all drupal caches.

Gacias

Hello.

The same problem persists in views that have the BEF (better exposed filters) activated and the apply and reset buttons is located below. They are not at the same level when the date selection filter is active.

Gracias

Hello.

I have found where these lines come from, they are from the admin Gin theme, they are the following lines:

table tbody tr {
  border-block-end: 1px solid var(--gin-border-color-table);
}

and

table thead tr {
  border-block-end: 2px solid var(--gin-border-color-table-header);
}

I altered the Gin css off this lines and works perfect.

Not sure if footable module may alter in views if is selected, for not alter with custom code.

Gracias

ady1503 → created an issue.

Hello.

It still doesn't work.
With the latest update it does not work to hide the group of fields if they are empty. I have tried both versions, the stable one and the dev version with the patch.
The empty group fields continues to be seen.

Thank you

ady1503 → created an issue.

ady1503 → created an issue.

I have tested the latest changes you made, everything works fine.
As I said above, if the administrator or authenticated role is chosen,
the entire bar is affected, with the chosen menus, and the default ones disappear.

It is not a bug as such, I am just reporting it so that users know.

Thanks for the module.

Hello.

What I mean is, if it is applied to the admin role then it modifies the bar completely, with the chosen menus, and the others disappear. It doesn't have much importance, it was for information.

Thank you.

Hello.

I understand that it is a job to do, I don't expect anything specific. The module is fine as long as you only need one menu and the same roles that have access. But it would be interesting to at least have the possibility of having more menus in the toolbar. The idea in itself is very good that the Gin theme has the possibility of activating menus with links.

I will use the existing functionality, but it is limited, and this means that many people do not use the module.

Gracias

Hello.

I think the problem persists.

When I saving the menu and role configuration, only the last menu of the configuration is visible in the menu bar.

Let me explain better: I go to the configuration page and add the menu first, the roles that should see them,
then I choose the second menu and the roles. But when I log in with a user that I gave permission to see both
menus in the bar, only the last menu is seen, the first is not seen.

I tried adding more menus and only the last one is always seen.

This is the first problem I saw.

Second:

And I also saw that the configuration affects the admin tool bar.
And that the bar is seen in other themes, not only in the gin admin theme as it should be.
For this reason it is called: Gin Toolbar Custom Menu.
It should affect only the "Gin" management theme.

Versión de Drupal
10.3.9
PHP
Versión
8.3.13

Thank you.

ady1503 → created an issue.

Hello.

Sorry for the delay.

Yes, I am going to sponsor you to add the new functionality.

It will have to be with the possibility of choosing between current mode and the new mode.

It will have to be through a checkbox or boolean-checkbox in the configuration of the field it controls.

In the field settings you have to add the option if you want the current mode to be highlighted all, or highlighte only field.

Thank you

ady1503 → created an issue.

Versión de Drupal
10.3.2
Gin 8.x-3.0-rc13

When I activate:

Enable sticky action buttons
Displays all actions of the form in the sticky header.

There are no save or cancel or dellete buttons on the views popup configurations.

I make refactoring of mi code to

  \Drupal::messenger()->addStatus(t('Dear %user, Welcome to our %site',['%user' => 'admin', '%site' => 'Drupal Learn']));
  // Prepare the goto Url.
  $url = Url::fromRoute('<front>');
  $response = new RedirectResponse($url->toString());
  $request = \Drupal::request();
  // Save the session so things like messages get saved.
  $request->getSession()->save();
  $response->prepare($request);
  // Make sure to trigger kernel events.
  \Drupal::service('kernel')->terminate($request, $response);
  $response->send();

and mi notifications works without patch 45, with theme gin and olivero.

source: https://blog.birk-jensen.dk/drupal-http-redirection-from-anywhere
https://www.drupal.org/node/2023537 →

  \Drupal::messenger()->addStatus(t('Dear %user, Welcome to our %site',['%user' => 'admin', '%site' => 'Drupal Learn']));
  $response = new RedirectResponse($url->toString());
  $request = \Drupal::request();
  // Save the session so things like messages get saved.
  $request->getSession()->save();
  $response->prepare($request);
  // Make sure to trigger kernel events.
  \Drupal::service('kernel')->terminate($request, $response);
  $response->send();

source: https://blog.birk-jensen.dk/drupal-http-redirection-from-anywhere
https://www.drupal.org/node/2023537 →

Works form mi for same problem with messenger after update to Drupal 10.3.0

Hope help.

I have applied all changes:

https://git.drupalcode.org/project/advanced_pwa/-/commit/5bf36319604f7e3...

and

patch number #18

and the end result is that everything works fine.

Thanks

Hello.

Tiredness is not good when taking tests.

In the end with your changes the module works.

You only have an error with these lines:

AdvancedpwaForm.php

/**
* {@inheritdoc}
*/
public function submitForm(array &$form, FormStateInterface $form_state) {
parent::submitForm($form, $form_state);
if (!empty(file_save_upload('icon_upload'))) {
$file = file_save_upload('icon_upload');
$filename = \Drupal::service('file_system')->copy($file[0]->getFileUri(), 'public://images/pwaimages/');
$form_state->setValue('icon_path', $filename);

}

Look at what is in bold that gives an error about the non-existent route.
That really does not exist, because this folder is not created when installing the module.

I'm going to test the functionalities, and I'll let you know.
I will test the push system to make sure it works correctly.

Thank you

PS.
Sorry for wrong evidence, I was tired.

Thank you for your work.

Later I will install a new drupal installation and try clean.

I never do tests in production.

The only thing I would like you to understand: if in the same test bench the PWA module works perfectly, but the advanced_pwa does not, it does not work and errors appear for a reason.

I'm not saying that your work is not well done, I'm just informing you, so I can help you improve.

Thank you

Hello.

I have tried your changes.

They do not work.

After investigating and analyzing I detected:

The pwa module creates the "pwa" folder and saves all the icons there, in the path:

"../files/pwa"

/home/***/public_html/main_domain/web/sites/default/files/pwa/android-chrome-512x512.png

/home/***/public_html/main_domain/web/sites/first_site/files/pwa/android-chrome-512x512.png

/home/***/public_html/main_domain/web/sites/second_site/files/pwa/android-chrome-512x512.png

URLs:

https://main_domain/sites/default/files/pwa/android-chrome-512x512.png

https://main_domain/sites/first_site/files/pwa/android-chrome-512x512.png

https://main_domain/sites/second_site/files/pwa/android-chrome-512x512.png

Your module creates the "advanced_pwa/icons" folder but it creates it in the "private" folder that is in the configuration and path:
"../files/private/advanced_pwa/icons"

/home/***/public_html/main_domain/web/sites/default/files/private/advanced_pwa/icons/android-chrome-512x512.png

/home/***/public_html/main_domain/web/sites/first_site/files/private/advanced_pwa/icons/android-chrome-512x512.png

/home/***/public_html/main_domain/web/sites/second_site/files/private/advanced_pwa/iconsandroid-chrome-512x512.png

URLs:

https://main_domain/system/files/private/advanced_pwa/icons/android-chrome-512x512.png

https://main_domain/system/files/private/advanced_pwa/icons/android-chrome-512x512.png

https://main_domain/system/files/private/advanced_pwa/icons/android-chrome-512x512.png

system is the format control of drupal for hide real private route and url for access control en private file system.

As you can see, the pwa module uses the free path outside the private folder, because I have access to the icon without being logged in.
The pwa module controls only which pages and roles the manifest file is loaded or not.

Not yours.

I'm just telling you your only biggest problem is: permissions.

And another thing in php 8.3 the following errors appear:

Warning: Undefined property: Drupal\advanced_pwa\Controller\AdvancedpwaController::$requestContext in Drupal\advanced_pwa\Controller\AdvancedpwaController->advancedpwaGetManifest() (line 190 of modules/contrib/advanced_pwa/src/Controller/AdvancedpwaController.php).
Drupal\advanced_pwa\Controller\AdvancedpwaController->advancedpwaGetManifest()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)


Warning: foreach() argument must be of type array|object, string given in Drupal\advanced_pwa\Form\ManifestConfigurationForm->submitForm() (line 445 of modules/contrib/advanced_pwa/src/Form/ManifestConfigurationForm.php).
Drupal\advanced_pwa\Form\ManifestConfigurationForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('advanced_pwa_settings_form', Array, Object) (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Warning: foreach() argument must be of type array|object, null given in Drupal\advanced_pwa\Controller\AdvancedpwaController->userHasSelectedRoles() (line 319 of modules/contrib/advanced_pwa/src/Controller/AdvancedpwaController.php).
Drupal\advanced_pwa\Controller\AdvancedpwaController->userHasSelectedRoles() (Line: 290)
Drupal\advanced_pwa\Controller\AdvancedpwaController->settings()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)


Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated in Drupal\advanced_pwa\Controller\AdvancedpwaController->settings() (line 276 of modules/contrib/advanced_pwa/src/Controller/AdvancedpwaController.php).
Drupal\advanced_pwa\Controller\AdvancedpwaController->settings()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

PS.

The pwa module works on all my sites with or without a private or public file system, in single domain or multidomain format.

As I explained above: the icons must be saved in /"../files/advanced_pwa/icons/".

And now it does it in ../files/private/advanced_pwa/icons/",

"../files/private/" is my folder configured in settings.php for private file system, and the drupal configuration to serve the files only in private mode.

Thank you

@solideogloria

Yes you're right.

But for me it works perfectly.

Because my notifications are to control access and number of content added. And stopping the script is not a problem.

I do redirect and then project the notification to inform the user that they do not have permission or have exceeded the number of allowed content.

I wanted to inform, if this is a reason for finding the drupal core problem, when it is solved I will return to the normal code.

Thank you.

Hello.

I inform you that works without any patch.

I am using olivero and gin drupal themes, core notifications works well. But:

For my custom code to work, type:

\Drupal::messenger()->addStatus(t('Dear %user, Welcome to our %site',['%user' => 'admin', '%site' => 'Drupal Learn']));

\Drupal::messenger()->addStatus(Markup::create('Duplicate Markup / string.'), TRUE);

exit(); <---

I have added only the exit() function, stop script.

I know it is not a correct solution, but in my functionality it works well for me.

I don't know why when adding exit(), after the notification functions works well.

Without exit(), custom notifications do not work. None, but with exit() at the end of the notifications function work.

I hope it is resolved correctly.

Gracias

Hello.

I inform you that your module works perfectly without any patch.

I am using olivero and gin drupal themes, core notifications works well. But:

For my custom code to work, type:

\Drupal::messenger()->addStatus(t('Dear %user, Welcome to our %site',['%user' => 'admin', '%site' => 'Drupal Learn']));

\Drupal::messenger()->addStatus(Markup::create('Duplicate Markup / string.'), TRUE);

exit(); <---

I have added only the exit() function, stop script.

I know it is not a correct solution, but in my functionality it works well for me.

I don't know why when adding exit(), after the notification functions your module works, and not just yours. But the others too. I have done tests. Without exit(), custom notifications do not work. None, but with exit() at the end of the notifications function it does work.

I hope it is resolved correctly.

Thanks for your module.

I have checked my installation.

When installing your module, the folder is not created: files/advanced_pwa/icons/.

When private file mode is activated. Here is your problem.

Because the pwa module has created the pwa folder for me in each subdomain that I have, in private file system.

You have to review the operation of the pwa module, how it creates the folders and checks the permissions and the file system that is activated in each installation.

What you tell me is file public system, not a private one.

Gracias

How I'm explaining it to you.

The pwa module works in my multidomain, multisite installations. I have the block with the button to install the app.
The installation of the web app works, the only problem is that they do not have a push system.
Works on private file system, loads icons. I can create an app using https://www.pwabuilder.com.
My subdomain format is https://subdomain.domain.com

I'm just looking to help.

My opinion on multidomain installations, multisite is possible. My multidomain, multisite drupal system doesn't share anything except the code. The databases are individual for each subdomain, I have common and individual modules.

The only thing I did was install its advanced_pwa module in an test subdomain and I couldn't use it.

Your system needs required that you generate keys first. This means that the key is unique for each domain, subdomain.

An url is individual and instalation folder too. I don't share the same content and configuration in mi system multidomain.

Report to be able to help get a module with complete PWA functionalities.

Thank you

https://web.dev/articles/building-multiple-pwas-on-the-same-domain

"After uploading the icon, can you access it as anonymous?
If you can't, I know the code to change. This would then save the file in the public files directory.
"

no not

"Are the multi sites sub-folders of the same domain?"

yes is same domain.

I have the entire file system in private mode. I had this error and the pwa module, they have added access control and they have to check which file system the drupal installation has. If it is private, you have to check the access permissions to the files in the controller. And serve the icons according to permissions and access.

Path: /system/files/advanced_pwa/icons/android-chrome-512x512.png. Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException: in Drupal\system\FileDownloadController->download() (line 82 of /home/***/public_html/***/web/core/modules/system/src/FileDownloadController.php).

Versión de Drupal
10.3.1

PHP
Versión
8.1.29

Path: /system/files/advanced_pwa/icons/android-chrome-512x512.png. Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException: in Drupal\system\FileDownloadController->download() (line 82 of /home/***/public_html/***/web/core/modules/system/src/FileDownloadController.php).

Drupal\Core\File\Exception\DirectoryNotReadyException: The specified file 'temporary://mstile-144x144.png' could not be copied because the destination directory 'public://images' is not properly configured. This may be caused by a problem with file or directory permissions. in Drupal\Core\File\FileSystem->prepareDestination() (line 457 of /home/***/public_html/***/web/core/lib/Drupal/Core/File/FileSystem.php).

Error: Call to a member function getCompleteBaseUrl() on null in Drupal\advanced_pwa\Controller\AdvancedpwaController->advancedpwaGetManifest() (line 190 of /home/***/public_html/***/web/modules/contrib/advanced_pwa/src/Controller/AdvancedpwaController.php).

Warning: Undefined property: Drupal\advanced_pwa\Controller\AdvancedpwaController::$requestContext en Drupal\advanced_pwa\Controller\AdvancedpwaController->advancedpwaGetManifest() (línea 190 de /home/***/public_html/***/web/modules/contrib/advanced_pwa/src/Controller/AdvancedpwaController.php)

ady1503 → created an issue.

ady1503 → created an issue.

I have done tests with patches together and separately. And I always emptied the Drupal cache.

Nothing works with the patches.

I say again without the izi and bigpipe patch, drupal core notifications work perfectly.

I have custom modules with \Drupal::messenger()->addStatus(t()) and they worked fine until the last core update.

Nothing works with the patches.

Yes, I have done tests together and separately. And I always emptied the Drupal cache.

Yes of course. I have used the bigpipe patch and it doesn't work either.

Hello.

The patch doesn't work.

Before the patch all core notifications worked, but custom notifications do not work due to the core 10.3.1 issue.

After the patch no notification works.

Thanks for the work, I will wait for the solution to the core 10.3.1 issue and activate your module again.

#45 NOT works for me on Drupal 10.3. Thanks.

I confirm all working.

Thanks for this module.

ady1503 → created an issue.

For this same reason I ask.

The list of checkboxes is an essential utility.

It doesn't have it either and the module:

https://www.drupal.org/project/datafield →

I understand that it is difficult at the structural level to make it possible to have the possibility of checkboxes.

Thanks for the work done.

ady1503 → created an issue.

It is simple.

Just add a number field and that's it.
This error appears when saving the new node also when editing.

And very important:

That the error is repeated for each field number of the custom_field in the same content type.

I also saw a strange thing.

When you create a new content type and save it, the keys appear and not the values. But if you go to Manage Presentation and simply change the presentation to key in any number field and save, all the number fields show the value and the one you changed shows the key, and then you put it back to value, everything is normal. You have to repeat this matter if you have added another number field, so that all the number fields present the values ​​and not the keys.

These errors appear only the first time when creating a new content type. Then they no longer appear.

Create a new content type, add a custom_field of number format.

Create the first one, and you will see the error, edit it and the error appears. But the following new ones created and edited no longer appear.

Gracias.

ady1503 → created an issue.

Hello.

This part of module make favicon invisible Progressive Web App Extras - pwa_extras module.

I uninstall this part, module pwa_extras and favicon is working vell.

Thanks.

@oliverpolden here is working example for year filter node

function yourmodule_views_query_alter(ViewExecutable $view, QueryPluginBase $query) {
  // make sure we're altering the correct view
  if ($view->storage->get('id') === 'your_view' && $view->current_display === 'your_display') {
    $currentYear = date('Y');
    $query->addWhereExpression(0, "EXTRACT(YEAR FROM FROM_UNIXTIME(node_field_data.created)) = :year", [':year' => $currentYear]);
    }
}

node_field_data.created is for created year

@oliverpolden i got the same issue but your patch not working Versión de Drupal 10.2.6.

It would be correct for this module to have the option to activate the current year automatically if none is indicated or it is left empty.

Thank you.

Hello.

After update to Versión de Drupal 10.2.6. To many errors apear without add Field Group Layout to content type:

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_builder/layouts/twocol_section/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_builder/layouts/twocol_section/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_builder/layouts/threecol_section/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_builder/layouts/threecol_section/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_builder/layouts/fourcol_section/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_builder/layouts/fourcol_section/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_discovery/layouts/onecol/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_discovery/layouts/onecol/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_discovery/layouts/twocol/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_discovery/layouts/twocol/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_discovery/layouts/twocol_bricks/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_discovery/layouts/twocol_bricks/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_discovery/layouts/threecol_25_50_25/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_discovery/layouts/threecol_25_50_25/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/core/modules/layout_discovery/layouts/threecol_33_34_33/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/core/modules/layout_discovery/layouts/threecol_33_34_33/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(/home/***/public_html/***/web/modules/contrib/vefl/layouts/onecol/templates/theme.inc): Failed to open stream: No such file or directory in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

Warning: include_once(): Failed opening '/home/***/public_html/***/web/modules/contrib/vefl/layouts/onecol/templates/theme.inc' for inclusion (include_path='/home/***/public_html/***/vendor/pear/archive_tar:/home/***/public_html/***/vendor/pear/console_getopt:/home/***/public_html/***/vendor/pear/pear-core-minimal/src:/home/***/public_html/***/vendor/pear/pear_exception:.:/opt/alt/php81/usr/share/pear:/opt/alt/php81/usr/share/php:/usr/share/pear:/usr/share/php') in include_once() (line 515 of core/lib/Drupal/Core/Theme/Registry.php).

When add to content type:

Deprecated function: strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated in Drupal\Core\Layout\LayoutPluginManager->Drupal\Core\Layout\{closure}() (line 204 of core/lib/Drupal/Core/Layout/LayoutPluginManager.php).

Deprecated function: strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated in Drupal\Core\Layout\LayoutPluginManager->Drupal\Core\Layout\{closure}() (line 204 of core/lib/Drupal/Core/Layout/LayoutPluginManager.php).

Deprecated function: strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated in Drupal\Core\Layout\LayoutPluginManager->Drupal\Core\Layout\{closure}() (line 204 of core/lib/Drupal/Core/Layout/LayoutPluginManager.php).

Deprecated function: strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated in Drupal\Core\Layout\LayoutPluginManager->Drupal\Core\Layout\{closure}() (line 204 of core/lib/Drupal/Core/Layout/LayoutPluginManager.php).

Deprecated function: strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated in Drupal\Core\Layout\LayoutPluginManager->Drupal\Core\Layout\{closure}() (line 204 of core/lib/Drupal/Core/Layout/LayoutPluginManager.php).

Warning: Undefined array key "field_layout" in Drupal\field_group_layout\Plugin\field_group\FieldGroupFormatter\LayoutFormatter->settingsForm() (line 81 of modules/contrib/field_group_layout/src/Plugin/field_group/FieldGroupFormatter/LayoutFormatter.php).

As you can see, it is affecting other modules that "Layout Builder" uses.

When I uninstall the module "Field Group Layout" there is no errors.

Thanks

Change to private file system please.

I say: Very important, my file system is "private".

before login:

after login:

Hello.

Is an default favicon.ico from theme.

I don't load any custom favicon.ico.

When user is anonimous user the favicon.ico is show in browser tab, but when user is login the favicon.ico is not show.

Thanks

ady1503 → created an issue.

ady1503 → created an issue.

Hello.

If possible, could you explain to me what is the reason for disconnecting html5 validation?

I have commented on this line and reviewed the code and I don't see anywhere the need to disconnect html5 validation.

I have done tests and so far it works for me.

I will keep you informed.

Thanks for the module.

// Turns off HTML 5 validation, as it breaks the validation/errors.
//$form['#attributes']['novalidate'] = 'novalidate';

ady1503 → created an issue.

Same issue.

Need patch.

I don't know why composer installed version 1.0.27.

All good.

Close the incident.

Thank you.

ady1503 → created an issue.

ady1503 → created an issue.

ady1503 → created an issue.

Hello.
jurgenhaas → , Can you present an example?
Of:
The selected value should be used as the fourth argument to the entity_print_views.view route and if it's not default, the \Drupal\entity_print_views\Controller\ViewPrintController::viewPrint method can call a new method in the print engine plugin to change the orientation.

Gracias

ady1503 → created an issue.

Solution is clear all caches.

@earthangelconsulting

Thank you so much.

Gracias

@earthangelconsulting

Can you show an real example?

Where did did you implement the code.

Thanks

Gracias

@AlfTheCat

Look here:

https://www.drupal.org/project/pwa/issues/3371404 🐛 Defined App Image Icon isn't used Fixed

ady1503 → created an issue.

In the end I have managed to find the problems that the manifest.json file does not load automatically.

First important point is that web browsers other than "Chromium" group does not work the PWA. In Firefox, the manifest.json and the block appear, but the add APP button does not appear, in Opera the add APP button appears but nothing does when clicked.

Second point for anonymous users to see the PWA block and for application to be available on the web page, you need to have active: "See published content" for all roles and for the anonymous role.

I think you need to add a permission group to the PWA. For example by roles: view PWA, view PWA block, etc. The issue of permissions has to be prioritized. I have a mechanism that controls who can see what is published, but for simpler cases it will not be correct. PWA has to be controlled by roles.

Another thing that would be important is the name of the file, instead of manifest.json, many sources on the web recommend:

NOTE: File extension: .webmanifest or .json?
The IANA registered file extension for the manifest is .webmanifest. Some web servers recognize this extension and transfer the file using the standardized application manifest media type (application/manifest+json). Developers can also choose a different extension (e.g. .json) or none at all (e.g. /api/GetManifest), but are encouraged to transfer the manifest using the application/manifest+json MIME type, although any JSON MIME type is ok.

With these changes, I get a decent PWA functionality in my project.
If my thoughts are correct add to the following version.

Gracias

I have found that causes the error:

TypeError: imagecopyresampled(): Argument #2 ($src_image) must be of type GdImage, bool given in imagecopyresampled() (line 424 of /home/***/public_html/***.com/web/modules/contrib/pwa/src/Form/ManifestConfigurationForm.php).

If the option that Drupal controls and serves the files is activated, it gives an error. If it is chosen that the web server does it, it does not give an error.

I think in this code is the error:
line 401
// Save new image.
$wrapper = $this->streamWrapperManager->getViaScheme(
$this->config('system.file')->get('default_scheme')
);
Because if I have the file system private, it looks in the folder declared private in settings, but by default the PWA saves the files in public.

Have need to add an if function to check the filesystem and allocate the correct one.

Another very important thing is to delete the cookies from the website. Not only the Drupal cache, to see the changes in the manifest.json file.

It also remains that manifest.json file does not load automatically.

Gracias

After update from issue:

$wrapper = $this->streamWrapperManager->getViaScheme(
$this->config('system.file')->get('default_scheme')
);
- $files_path = '/' . $wrapper->basePath() . '/pwa/';
+ $files_path = \Drupal::service('file_url_generator')->generateString("public://pwa") . '/';
$file_uri = $files_path . $file->getFilename();

- $file_path = $wrapper->realpath() . '/pwa/' . $file->getFilename();
+ $file_path = $wrapper->realpath() . '/' . $file->getFilename();

$config->set('image', $file_uri)->save();

I have this error en browser logo of developer state:

The FetchEvent for "https://***.com/manifest.json" resulted in a network error response: a redirected response was used for a request whose redirect mode is not "follow".

And in drupal logo:

TypeError: imagecopyresampled(): Argument #2 ($src_image) must be of type GdImage, bool given in imagecopyresampled() (line 424 of /home/***/public_html/***.com/web/modules/contrib/pwa/src/Form/ManifestConfigurationForm.php).

manifest.json still not loading.

There are also problems with deleting This image is your application icon. (png files only, format: (512x512), when add or delete icon.

Thanks for help.

ady1503 → created an issue.

Hello.

How is it possible to add the orientation in each of the views page.

In the configuration of the view, in global print add the possibility of choosing the orientation of the page, so that it is not default as it is now.

When it is chosen in the general configuration, the orientation of the page is the same for all.

I would like to add the possibility at least to the views page to choose the orientation for each individual one.

Thank you.

In views global head or footer add:
Global text area with filtred text
Provide markup for the area using any available text format.

And add the folow

<button onclick="window.print()"><strong>Print this page</strong></button>

This will put an botton for print the curent view page.

For mi is work well. Thanks Ruslan Piskarov for an idea.

Thanks.

I made changes in mi site and works.

You are right, it is the solution.

Commit this.

ady1503 → created an issue.

I confirm that, it does not work with anonymous users and neither with all authenticated users.

On my site, users with the power to create content do see and can utilize the PWA button. But without, no.

I think it will be necessary to add the access control in the PWA module.

For mi, mi changes working well.

Don't forget, the manifest.json file is not loaded automatically.

Hello.

I made this:

Using the rebuild script
Open settings.php (/sites/default/settings.php) in any plain text editor. Add this line to the end of the file and save it:

$settings['rebuild_access'] = TRUE;
Visit http://www.example.com/core/rebuild.php in your browser (where www.example.com is your site’s URL). After a short pause, you should be redirected to the home page of your site, and the cache should be rebuilt.
Open settings.php (/sites/default/settings.php) in a text editor. Find the line you added with $settings[rebuild_access], remove this line, and save the file.

In drupal 10.1.1 and works all, and this is for #3370828: Ensure that edge caches are busted on deployments for css/js aggregates, too.

If you want delete an cache.

Thanks

For the PWA and the APP installation to work you have to load the manifest.json manually at the link yoursite.com/manifest.json .

It's a bug in the main module, it doesn't load the file automatically.

If you have loaded the logo before drupal version 10.1.1 load the manifest.json file manually and it will work.

In drupal 10.1.1 it is not possible to add the logo of the app, it gives an error and the PWA module cannot be used. I have opened an issue.

I found that the problem persists if both options are activated:

Bandwidth Optimization
External resources can be automatically optimized, which will reduce both the size and the number of requests to your website.

Combine CSS files

Merge JavaScript files

I have made the following changes:
in pwa_a2hs.libraries.yml
dependencies:
- core/drupalSettings
- core/jquery
- core/once

and

in js/pwa_a2hs_prompt.js

(function ($, Drupal, once) {
'use strict'

// Use jQuery once() so the button doesn't get added multiple times.
$(once('showButton', '.pwa-a2hs', context)).each(function () {

})(jQuery, Drupal, once);

And the "Install APP" button works.

Commit if is correct.

Thanks

ady1503 → created an issue.

ady1503 → created an issue.

ady1503 → created an issue.

Hello

@wildcats369 with patch work well.

https://www.drupal.org/project/vefl/issues/3341550 🐛 TypeError: Illegal offset type in isset or empty Needs review

Thanks