Collapsible details element not hidden if "Hide filter, if no options" is selected.

Could you provide steps for reproducing this?

If still a problem in 6.0.x please reopen

This is still an issue, at least when used with the latest Facets 3.x

1. Configure facets within Views as documented in https://project.pages.drupalcode.org/facets/exposed_filters/
2. In Better Exposed Filters settings on the view, under Exposed Filter Settings, open Advanced filter options and enable Make filter options collapsible ("Puts the filter options in a collapsible details element.")
3. Visit the view and filter by another facet so one set to be in a Details element has no results.
4. Note that the facet label is still there as the summary for the details element, but nothing is inside.
5. Change the Exposed Filter Settings option to not make filter options collapsible.
6. Reload the view and see that now the facet label is gone, as expected.

Should be verified in 7.0.x first

Thanks, i realized that after posting and upgraded, and it is still the case on 7.0.2 at least.

Configurable Views Filter Block shows Better Exposed Filters facets-sourced Details elements (label, no options) even when not selected in the block if that is helpful for pointing me at where to try to fix this. Thanks!

Nothing like writing ones own Better Exposed Filter plugin - https://www.drupal.org/project/bef_links_filter → - to get a better sense of how this all works. Implemented a workaround in 🐛 Prevent collapsible fieldset from showing when facet is empty Active but the fix here should be to put the wrapping of facet into a details element on line 254 of better_exposed_filters/src/Plugin/better_exposed_filters/filter/FilterWidgetBase.php in a if (!empty($form[$field_id])) { … } block, unless that does not work for all better_exposed_filter plugins?

I have 0 idea how to test this with just in bef but if it works with facets I can merge it.

Happy to confirm #10 works for me on BEF 7.0.4 with Facets 3.0.0. Thanks for the fix!

laborouge → changed the visibility of the branch 3379736-collapsible-details-element to hidden.

smustgrave → closed merge request !133

This commit breaks putting wrapped filters in a collapsible detail element. It looks like a similar issue to # 3475063 🐛 Hide labels for wrapped filters Active where the form field id is "field_name" + "_wrapper". Maybe we can solve both by tweaking getExposedFilterFieldId. I tried looking into it but can't find a clear indication that the field is a wrapped multi-field.

I solved the issue for myself by extending the bef Radios/Checkboxes filter and using it for my facets.

    // Remove corresponding details if no options.
    if (empty($form[$field_id]) && empty($form[$field_id . '_wrapper']) && isset($form[$field_id . '_collapsible'])) {
      unset($form[$field_id . '_collapsible']);
    }

This also checks for the `_wrapper` element as @johnny5th suggested might work.

I'm also using the extension to manage the conditional visibility of facets, which is already a won't fix in bef: ✨ Add support for conditional exposed filters in views Closed: works as designed

After this commit am no loner able to collapse slider widget in the views exposed form.

It seems to change from details element to fieldset, and I cannot see how to alter this.

Downgrading to 7.0.4 is simplest fix for me - hoping this gets fixed for next release

The same thing happens to me. I have left it at version 7.0.4:

"After this commit am no loner able to collapse slider widget in the views exposed form.

It seems to change from details element to fieldset, and I cannot see how to alter this."

Downgrading to 7.0.4 is simplest fix for me

Gracias

Separate issue should be opened for sliders