Hiding empty field groups in form display is not working

I've hit a similar issue with a profile element nested in a Tab. Unfortunately, the patch doesn't work.

refs → made their first commit to this issue’s fork.

I refactored the code from @Rob320 a bit and reduced the loops.

The structure of the check is now also more similar to field_group_remove_empty_display_groups.

I tested it with nested paragraphs, each of which has nested field groups.

Hello.

It still doesn't work.
With the latest update it does not work to hide the group of fields if they are empty. I have tried both versions, the stable one and the dev version with the patch.
The empty group fields continues to be seen.

Thank you

Added a re-roll to apply to 8.x-3.6 based on patch in #4

Patch #14 is not working for us on version 3.6. All field groups are always empty...
Tried without the patch and it seems to be working just fine. Not sure why the patch is still needed?

The patch in #14 was incorrect, a bad re-roll on my part. I've fixed this - as to whether the patch is needed or not, I don't know - I'm just updating a project using it so better to keep the change in, than removing it.

The field permissions part of the STR to might be key though?

Rebased MR on current main. The rebase reverts code changes done in #3098550: Nested groups render on other entity forms (or when fields are inaccessible) when they shouldn't → .
The added test still passes.

#3098550: Nested groups render on other entity forms (or when fields are inaccessible) when they shouldn't → introduced also a check for empty field groups

// If the element is a group, check if it is empty or not.
$empty_element = in_array($child_name, $groups) ? $empty_groups_indication[$child_name] : $empty_element;

I don't know if this Issue is still needed. 3098550 sorts the children and first checks the fields and then the groups if they are empty. This MR checks the fields and groups recursive using the group hierarchy.

I will update my projects to field_groups 4 soon and then check them without the patch from this MR.