- Issue created by @sergiur
- Assigned to Tirupati_Singh
- Merge request !80Issue #3473969: Fixed the horizontal-tabs double border issue. → (Open) created by Tirupati_Singh
- Issue was unassigned.
- Status changed to Needs review
3 months ago 10:05am 16 September 2024 - 🇮🇳India Tirupati_Singh
Hi @sergiur, I've fixed the double border being rendered for the horizontal tabs due to claro-details class. The claro-details class is being added due to the changes made in the feature request Add classes to JS rewriting in horizontal tabs ✨ Add classes to JS rewriting in horizontal tabs Fixed . I've attached the before and after fixes screenshots for your reference. Please review the changes.
Thanks!
- 🇬🇧United Kingdom sergiur London, UK
That works for me -- I haven't seen any negative impact of removing the class in this way, it still gets added to the actual details elements you see by default and on mobile, but it's just not needed on the horizontal tabs.
- 🇩🇪Germany Anybody Porta Westfalica
Instead of removing
.claro-details
is it possible to only add it where deserved?
Furthermore I don't really like adding theme-specific code in a module. Any better ways?If there's definitely no better way, at least add an inline comment to explain why this is needed.
- 🇮🇳India Tirupati_Singh
Added comment regarding the changes made. Please review the MR.
Reviewed MR !80 The suggested changes were made and also tested changes made by MR !80, Attaching Screenshots for reference. RTBC++