- Issue created by @raywalters
- πΊπΈUnited States raywalters
This is now passing ESLint and ready for review. https://git.drupalcode.org/issue/restrict_ip-3405330/-/pipelines/64579
- Status changed to Needs review
about 1 year ago 10:32pm 15 December 2023 - Status changed to RTBC
about 1 year ago 8:46pm 19 December 2023 - First commit to issue fork.
- π©πͺGermany Anybody Porta Westfalica
@raywalters and @pilot3: eslint is still unhappy:
/builds/project/restrict_ip/web/modules/custom/restrict_ip/js/mail_fix.js 9:3 error .ready is not allowed no-jquery/no-ready β 1 problem (1 error, 0 warnings)
- π©πͺGermany Anybody Porta Westfalica
Thanks @sandip poddar, but just muting ESLint is not a fix. Please fix the issues instead.
@anybody can you please guide me should i remove jquery from the codebase and can we use Drupal Behaviors here? As in the code it is mentioned we cannot use Drupal behaviors also.
/* jslint white:true, multivar, this, browser:true */ // eslint-disable-next-line func-names (function ($) { // We do not use Drupal.behaviors, as the Drupal object // is not available due to drupal.js having been removed // eslint-disable-next-line no-jquery/no-ready, func-names $(document).ready(function () { const mailDiv = $('#restrict_ip_contact_mail'); const contactMail = mailDiv.text().replace('[at]', '@'); mailDiv.html(`<a href="mailto:${contactMail}">${contactMail}</a>`); }); })(jQuery);
- πΊπΈUnited States smustgrave
Fixing the pipeline on π Update pipeline for 5.0.x Active