🇺🇸United States @raywalters

raywalters → created an issue.

Reviewed and verified that phpunit tests are passing in the pipeline.

Reviewed and can verify that eslint is passing in the pipeline.

Reviewed and can verify that this passes the phpcs tests in the pipeline.

Reviewed and can verify that the phpcs tests pass in the pipeline.

Reviewed and can verify that this passes phpstan testing in the pipeline.

I have reviewed the MR and can verify that this is now passing tests.

This is now passing ESLint and ready for review. https://git.drupalcode.org/issue/restrict_ip-3405330/-/pipelines/64579

Applying the merge request patch in this issue along with the merge request from https://www.drupal.org/project/ui_patterns/issues/3335833 🐛 Patterns library doesn't detect other activated theme patterns (only from the basetheme) RTBC for ui patterns resolved my issue. Twig\Error\LoaderError: Template "modules/contrib/ui_patterns/templates/pattern-teaser.html.twig" is not defined. in Twig\Loader\ChainLoader->getCacheKey() (line 10 of /var/www/html/docroot/modules/contrib/ds/templates/ds-entity-view.html.twig).

I needed to apply this patch along with the merge request diff from https://www.drupal.org/project/components/issues/3107993 🐛 Template is not defined error on admin pages when using administration theme Needs work for components to resolve the my error on the views admin page.

raywalters → created an issue.

raywalters → created an issue.

I removed the phpstan ignore comments to fix the warnings. This is now passing the phpstan errors in gitlab ci. The phpcs issues are fixed in https://www.drupal.org/project/workbench_reviewer/issues/3402553 📌 Fix phpcs issues reported by Gitlab CI RTBC .

raywalters → created an issue.

Closing this issue as the module is only for D7.

@agentrickard, you are correct. I am going to close this issue.

Reviewed and can confirm that gitlab-ci.yml file was added and tests are running. There are some phpcs and phpstan warnings that can be addressed in another issue.

I reviewed and can verify that the gitlab-ci.yml file was added. Looks like we need to address some phpcs and phpunit issues which can potentially be handled in another issue.

PHPCS tests are now passing.

raywalters → created an issue.

I have reviewed that the gitlab-ci.yml file has been added to the repo.

I have reviewed that the gitlab-ci.yml file has been added to repo.

raywalters → created an issue.

raywalters → created an issue.

I applied the patch from MR !2 and can confirm that this is working as expected.

Reviewed and verified that tests are running with GitlabCI.

Reviewed and verified that tests are passing. RTBC.

I was able to successfully apply patch #20 on version 1.4 without issues.