Fix the issues reported by phpcs

The patch #4 has been reviewed and applied cleanly, but a few phpcs still remain.

FILE: ...\modules\workbench\src\Controller\WorkbenchContentController.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
138 | WARNING | [ ] Unused variable $key.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: C:\xampp\htdocs\abc\drupal\modules\workbench\workbench.api.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but
| | found "\r\n"
30 | ERROR | [ ] @return doc comment specified, but function has no
| | return statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

I have fixed the above issues

Thanks

Patch #7 applied cleanly, and all errors and warnings are fixed.
So moving it to RTBC.
Thanks

Tests failed, though.

PHP Parse error:  syntax error, unexpected '->' (T_OBJECT_OPERATOR) in /var/www/html/modules/contrib/workbench/src/Plugin/Block/WorkbenchBlock.php on line 41
xargs: php: exited with status 255; aborting

-    $items = \Drupal::moduleHandler()->invokeAll('workbench_block');
+    $items = this->moduleHandler->invokeAll('workbench_block');

this should be $this.

I have fixed the '$this' issue. Please review this patch.

All errors and warnings are fixed now.
I have updated the MR.
Moving it to RTBC

Thanks

Tests still need to run.

Verified the MR!2 on Drupal version 10.1.x and Workbench version 8.x-1.x. All the coding standard issues are fixed after applying the patch.

 use Drupal\Core\Form\ConfigFormBase;
 use Drupal\Core\Form\FormStateInterface;
+use Symfony\Component\DependencyInjection\ContainerInterface;
+use Drupal\Core\Entity\EntityTypeManagerInterface;

Those statements are usually ordered alphabetically.

  * @param array $output
  *   A Render API array of content items, passed by reference.
- * @param $context
+ * @param string $context
  *   A string context for the request, defaults to overview|edits|all.
  *
- * @return array
- *   A renderable array or an array keyed with a #view_id and #view_display
- *   to indicate which View display to load onto the page.
- *
  * @see WorkbenchContentController::renderBlocks()
  */
-function hook_workbench_content_alter(&$output, $context = NULL) {
+function hook_workbench_content_alter(array &$output, $context = NULL) {

Since it is a change for a documentation file, is that really necessary? If it is necessary, then also $context should be type-hinted.

Reviewed your patch #20, Most of issues are fixed but still one warning with your patch.
getting warning while applying patch.

The last submitted patch, 20: fix_coding_standard-3334870-20.patch, failed testing. View results →

I was able to successfully apply patch #20 on version 1.4 without issues.

Providing updated patch and fixing trailing whitespace issue.

Please review. Thanks.

I have updated the code in gitlab with the contents of the patch file in #25.

Please review.

The last submitted patch, 25: fix_coding_standard-3334870-25.patch, failed testing. View results →

Please do not RTBC things that have no test runs.

This will be merged as part of 📌 Move automated testing to GitLab Active

I'm going to mark this as fixed, merge, and then follow-up in the linked issue.

Automatically closed - issue fixed for 2 weeks with no activity.