- Issue created by @mably
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 8:05am 7 December 2023 - ๐ฎ๐ณIndia chetan 11
Hi,
I have fixed the above error in my local setup, please check the raised MR.
Thanks. - ๐ซ๐ทFrance mably
Looks like some ChatGPT generated code that doesn't work.
- ๐ซ๐ทFrance sad270
Hello,
Why do you need to have both of these modules installed? By design, their purpose is the same, and so they should not be used conjointly.
If the need is to useFileInsertHookHandler
inimageapi_optimize
, it will be more appropriate to implement the feature inimageapi_optimize
directly. Like this you will need only one module. Disabling the image style handling in this module to only use theFileInsertHookHandler
for another module simply diverge from this module's reason to be: keep it simple in an opinionated way.
To avoid any future confusion, we will add an explicit conflict in ourcomposer.json
- Status changed to Closed: works as designed
6 months ago 9:45am 1 July 2024 - ๐ซ๐ทFrance CurriedN
Since both modules are supposed to do the same thing and there is no answer on last comment, I'm closing this issue too.