Log warning when relatable resource type references a missing entity type / bundle instead triggering E_USER_WARNING

samit.310@gmail.com → made their first commit to this issue’s fork.

Refactor seems fine.

Not sure about this one, the original issue this was added in was #2996114: Argument 2 passed to Drupal\jsonapi\Routing\Routes::Drupal\jsonapi\Routing\{closure}() must be an instance of Drupal\jsonapi\ResourceType\ResourceType, NULL given → and it looks pretty clear from that issue that people were seeing this issue on runtime, not necessarily during development. So if we change it to an exception, they could suddenly get an unusable site. I didn't read all 160+ comments on that issue, but needs more thought IMO.

We can't deprecate right? That would block updating to phpunit 10 in D10. So is there any alternative?

The alternative is logging a warning with the logger service instead of trigger_error(), we could open a follow-up to look at throwing an exception, but I think hitting this code path is a symptom of something else being wrong, and it would be better to throw exceptions there (config import?).

Ah didn't think of just logging. Thought the only options were trigger_error or exception.

Thanks for showing that @quietone

This issue titles should be about the runtime code being changed. The test change is secondary. It's way more important that the E_USER_WARNING is being replaced with a logged warning message.

Committed and pushed bcf45f5d87 to 11.x and 9c865d11f3 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.