- Issue created by @mondrake
- Status changed to Needs review
6 months ago 8:59pm 24 March 2024 - 🇮🇹Italy mondrake 🇮🇹
Creating dummy doubles that have no correspondence to methods in the SUT is code smell.
Looking at how this was (ab)used, in this case I think the deprecation of this method is really a good step. In some cases we did not even need a mock, in other there were hidden bugs.
- Status changed to RTBC
6 months ago 12:02pm 26 March 2024 - 🇳🇱Netherlands Spokje
Explanation and code changes make sense. Overall a nice cleanup!
- Status changed to Needs work
6 months ago 12:15pm 26 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Can the issue summary be completed. It helps modules that have to replace the same things.
The MR looks great - much better to be be testing with real classes in more places.
- Status changed to RTBC
6 months ago 1:12pm 26 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed b73c68de45 to 11.x and 4869fb9aa6 to 10.3.x and bdcf4705fa to 10.2.x. Thanks!
Backported to 10.2.x to keep test coverage aligned.
-
alexpott →
committed bdcf4705 on 10.2.x
Issue #3433086 by mondrake: Method addMethods() of class PHPUnit\...
-
alexpott →
committed bdcf4705 on 10.2.x
-
alexpott →
committed 4869fb9a on 10.3.x
Issue #3433086 by mondrake: Method addMethods() of class PHPUnit\...
-
alexpott →
committed 4869fb9a on 10.3.x
- Status changed to Fixed
6 months ago 5:05pm 26 March 2024 -
alexpott →
committed b73c68de on 11.x
Issue #3433086 by mondrake: Method addMethods() of class PHPUnit\...
-
alexpott →
committed b73c68de on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.