Downgrade (temporarily) nikic/php-parser to ^4

Not a big fan of lowering versions of dependencies, but seeing that:

- None of our other dependencies need it
- Tests are green
- PHPUnit 10 waits for no man...

I'm going to RTBC

I;ve read https://github.com/phpstan/phpstan/issues/7943 and it states quite clearly that

Upgrading is not blocked by PHPStan. You can use PHPStan in projects that use PHP-Parser v5.

Reading 📌 Remove DrupalComponentTestListenerTrait and replace with a PHPStan rule RTBC it sounds like the real issue is with DebugClassLoader

@alexpott the problem is described here https://github.com/phpstan/phpstan/issues/10620#issuecomment-1959440979

You can USE PHPStan for static analysis, but you cannot TEST your own rules.

So the solution is also written there...

The rare problem happens when you're mixing the two versions at runtime. So if you run tests for something that loads PHP-Parser v5, it's going to crash PHPStan's tests which need PHP-Parser v4.

The solution is to test these things separately. @group the PHPStan extensions tests and run them in a separate CI target.

Given how PHPStan runs we can hit this problem in the future. If we adding PHPStan tests to core then we're going to need to run them separately.

This will also prevent us from going to PHPUnit 11, though I suppose we cross that bridge when we come to it: https://github.com/sebastianbergmann/php-code-coverage/blob/main/compose...

Looks like this needs more discussion.

I think it would be fine to exclude phpstan tests in the main phpunit job and add a new job, which could then manually downgrade nikic/php-parser?

#13 locally I solved by running composer require nikic/php-parser:^4, and the test passes (it throws some debugclassloader deprecations that we'll have to silence, but one thing at a time).

So we can
a) downgrade like here
b) create a separate job to just run PHPUnit on PHPstan rules, downgrading via composer require nikic/php-parser:^4 on each run
c) mark the test skipped in 📌 Remove DrupalComponentTestListenerTrait and replace with a PHPStan rule RTBC while we wait for PHPStan 2

To me this one seemed the lightest to do, and in any case is temp. If we do want to do b) for more separation, then it's another discussion, and I think should happen in 📌 Remove DrupalComponentTestListenerTrait and replace with a PHPStan rule RTBC .

I'm for B. I think or PHPStan test should not use our root composer.json for installing and testing things. Or perhaps even better and maybe option D, we should not put the PHPStan rules in core. Can we contribute them to mglaman's package or can we add another package.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Would this need to be done before 10.3?

As discussed in the parent, we will likely go for a decoupling of the PHPStan rule tests from Drupal core test, so this is not going to be necessary.