- Issue created by @mondrake
- 🇮🇹Italy mondrake 🇮🇹
I think this finds a bug: call count expectations for mocks created in dataproviders (in PHPUnit 9, in 10 this will no longer be a problem) are not checked. So moving the mock creation to the test as in this MR we actually fix the bug.
- Status changed to Needs review
8 months ago 12:31pm 7 April 2024 - 🇮🇹Italy mondrake 🇮🇹
Practically
LinkNotExistingInternalConstraintValidatorTestwas rewitten - a large part of the test was configured in the data provider, which cannot stand. So better have independent tests (these are unit tests) and common code be put in a helper function. - Status changed to Needs work
8 months ago 2:10pm 8 April 2024 - 🇺🇸United States smustgrave
Not sure why but re-ran the failing javascript tests 3 times and they failed each so doesn't appear to be random.
- Status changed to Needs review
8 months ago 2:54pm 8 April 2024 - 🇮🇹Italy mondrake 🇮🇹
Tried rebasing. The MR is only touching test code, so I'm having hard time to understand how this could fail a totally different test.
- Status changed to RTBC
8 months ago 3:43pm 8 April 2024 - 🇺🇸United States smustgrave
Ended up getting a random functional test this time haha. Re-ran that though and it passed.
So as of now it's green.
- Status changed to Fixed
8 months ago 4:32pm 8 April 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.