Incompatibility with media_entity_download

Created on 20 December 2023, about 1 year ago

Problem/Motivation

When using media_entity_download, you are allowed to try to force the disposition of the download.

But reverse_proxy_header adds

$event->getRequest()->overrideGlobals();

which will convert any query args like "inline => NULL" to "inline -> ''(empty string)".
That will convert any link like media/2/download?inline to media/2/download?inline=(see equals), which causes an unnecessary redirect (and might lead to unexpected bugs).

I wonder why this is needed at all, given that we set the values that we need (HTTPS and REMOTE_ADDR).

Steps to reproduce

TBD

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

TBD

API changes

TBD

Data model changes

TBD

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024