- Merge request !27Issue #3331284: Fix PHP 8.2 deprecation issue with CronRule-class → (Merged) created by j-vee
- Status changed to RTBC
about 1 year ago 2:29pm 31 August 2023 - Issue was unassigned.
- 🇺🇸United States DamienMcKenna NH, USA
I think this is actually a typo - there's a class variable defined called $last_run, but then the rest of the code uses $this->last_ran. So while this patch will fix the issue, it leaves behind an unused variable.
private $last_run; private $next_run;
The code already has both last/next RUN, so we should leave the declaration alone and fix the uses.
- Status changed to Needs work
about 1 year ago 6:26pm 19 October 2023 The code also declares a dynamic property "parsed", so that should be added.
private $parsed;
- last update
about 1 year ago 32 pass - Status changed to Needs review
about 1 year ago 10:18pm 23 October 2023 - last update
about 1 year ago 25 pass, 4 fail - last update
about 1 year ago 25 pass, 4 fail - last update
about 1 year ago 32 pass - Status changed to RTBC
about 1 year ago 7:25am 25 October 2023 - 🇧🇬Bulgaria pfrenssen Sofia
Looks good, thanks! It would be great to see the PHP 8.2 tests green, but the main development branch is already failing on 8.1+
- 🇺🇦Ukraine quadrexdev Lutsk
Thanks, @solideogloria. Applied the patch from #11 on my project and it fixed the issue.
+1 to RTBC
- First commit to issue fork.
- last update
10 months ago 32 pass - Status changed to Fixed
10 months ago 10:18am 3 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.