I extended the patch in #5 for my use case. It still feels like a hack as it's just running a couple of preg_replace on the markup.
#5 failed for me when using x1 and x2 sized images for high definition devices. Only the first path was converted, so I was left with something like:
<source srcset="https://my.site.com/sites/default/files/styles/media_xl_1x/public/myfile.jpg 1x, /sites/default/files/styles/media_xl_2x/public/myfile.jpg 2x" media="all and (min-width: 1536px)" type="image/jpeg" width="3840" height="2160">
Previous patch does not apply. This one does.
rjjakes → created an issue.
Thanks for the offer. I have added you as maintainer. You should be able to push to a new 11.x branch and create releases.
I raised MR3 which tested as applying.
Yes this is still an issue for 2.x
I have re-rolled for 2.x
Resolved as part of https://www.drupal.org/project/bootstrap_kit/issues/3146295 📌 Automated Drupal 9 compatibility fixes Fixed
Merged to 4.x
Merged to 4.x
I've been added as a maintainer and have created D10 compatible release.
Merged to 1.x-dev
Switching back to active.
I have created a tag in git. I don't have permission to create a release on the page, but there is a D10 tag.
Project page: https://www.drupal.org/project/adminimal_theme →
@gisle I've created the issue https://www.drupal.org/project/adminimal_theme/issues/3376041 → and messaged @ANDiTKO
I'm also interested. I support a number of large modules and can opt in to security coverage.
As per #6 https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
the project page is: https://www.drupal.org/project/bootstrap_kit →
Merged to dev.
D10 release has been created https://www.drupal.org/project/rename_admin_paths/releases/8.x-2.2-beta1 →
Merged to 1.x
rjjakes → created an issue.
Thanks. Confirmed fixed.
I've merged this to 2.x
It will included in the next alpha-3
rjjakes → made their first commit to this issue’s fork.
Thanks. I have created a new release with this included.
Thanks. I have created a new release with this included.
The MR needs rebasing.
Hi @n.ghunaim - can you open a new issue with details please.
Merged to 8.x-1.x
I merged the fix by xaviemirmon to 8-x.1-x as this fixed the underlying issue instead of working around it.
Due to all the recent merges to 8.x-1.x this needs rebasing but has conflicts
Merged to 8.x-1.x
Merged to 8.x-1.x
Merged to 8.x-1.x
Re-opening. See patch.
Re-opening as found related issue.
Re-opening as found new issues with layout builder cache during testing.
Pushed to 8.x-1.x
Re-opening as I've spotted more instances of "Drupal 8" in various admin titles and descriptions.
Thanks. This seems to have crept in during all the recent merges.
I have merged https://www.drupal.org/project/we_megamenu/issues/3006302 🐛 Configurations not saving Fixed to 8.x-1.x
You can test to see if this resolved your issue. If so, I can close this issues as a duplicate.
Pushed to 8.x-1.x
Pushed to 8.x.1-x
@shivam_tiwari - you've just committed the patch file to the repo. That's not a valid way of working.
Merged to 8.x-1.x
Resolved as part of https://www.drupal.org/project/we_megamenu/issues/3300703 📌 Drupal 10 readiness Fixed
Merged to 8.x-1.x
Merged to 8.x-1.x
Merged to 8.x-1.x
Both MRs now have conflicts. It's unclear from the thread which MR is correct to merge anyway.
The latest MR now has conflicts that need resolving.
Merged to 8.x-1.x
Merged to 8.x-1.x
Merged to 8.x-1.x
Merged to 8.x-1.x
Add commit credit for pookmish
Merged to 8.x-1.x
Patch mostly duplicates https://www.drupal.org/project/we_megamenu/issues/3300703 📌 Drupal 10 readiness Fixed
Merged the remaining diff to 8.x-1.x
Merged to 8.x-1.x
Patches provided by t1mm1 look the cleanest of the D10/PHP8 patches. I will merge this one and resolve conflicts for others and merge.
Thanks @vpa24 I have pushed your patch.
Pushed to 8.x-1.x
I've merged the other D9 ticket to 8.x-1.x
I will move toward a formal release after some more testing.
Merged to 8.x-1.x
Merged into 8.x-1.x
Done and committed to 8.x-1.x
I would like maintain this module. I have experience maintaining large modules with security coverage.
This module is used internally at my organization so would benefit from commercial sponsorship.
I already have a patched D9 and D10 version available so can quickly move to a release for this.
I made a mess of the MR (reapplied the patch), but cleaned it up and merged to 2.x
Merged to 8.x-1.x