Account created on 8 June 2016, almost 9 years ago
#

Merge Requests

Recent comments

🇬🇧United Kingdom rjjakes

I extended the patch in #5 for my use case. It still feels like a hack as it's just running a couple of preg_replace on the markup.

🇬🇧United Kingdom rjjakes

#5 failed for me when using x1 and x2 sized images for high definition devices. Only the first path was converted, so I was left with something like:

<source srcset="https://my.site.com/sites/default/files/styles/media_xl_1x/public/myfile.jpg 1x, /sites/default/files/styles/media_xl_2x/public/myfile.jpg 2x" media="all and (min-width: 1536px)" type="image/jpeg" width="3840" height="2160">

🇬🇧United Kingdom rjjakes

Thanks for the offer. I have added you as maintainer. You should be able to push to a new 11.x branch and create releases.

🇬🇧United Kingdom rjjakes

I raised MR3 which tested as applying.

🇬🇧United Kingdom rjjakes

Yes this is still an issue for 2.x

I have re-rolled for 2.x

🇬🇧United Kingdom rjjakes

Resolved as part of https://www.drupal.org/project/bootstrap_kit/issues/3146295 📌 Automated Drupal 9 compatibility fixes Fixed

🇬🇧United Kingdom rjjakes

I've been added as a maintainer and have created D10 compatible release.

🇬🇧United Kingdom rjjakes

I have created a tag in git. I don't have permission to create a release on the page, but there is a D10 tag.

🇬🇧United Kingdom rjjakes

I'm also interested. I support a number of large modules and can opt in to security coverage.

🇬🇧United Kingdom rjjakes

Thanks. I have created a new release with this included.

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Hi @n.ghunaim - can you open a new issue with details please.

🇬🇧United Kingdom rjjakes

I merged the fix by xaviemirmon to 8-x.1-x as this fixed the underlying issue instead of working around it.

🇬🇧United Kingdom rjjakes

Due to all the recent merges to 8.x-1.x this needs rebasing but has conflicts

🇬🇧United Kingdom rjjakes

Merged to 8.x-1.x

🇬🇧United Kingdom rjjakes

Merged to 8.x-1.x

🇬🇧United Kingdom rjjakes

Re-opening. See patch.

🇬🇧United Kingdom rjjakes

Re-opening as found related issue.

🇬🇧United Kingdom rjjakes

Re-opening as found new issues with layout builder cache during testing.

🇬🇧United Kingdom rjjakes

Re-opening as I've spotted more instances of "Drupal 8" in various admin titles and descriptions.

🇬🇧United Kingdom rjjakes

Thanks. This seems to have crept in during all the recent merges.

🇬🇧United Kingdom rjjakes

I have merged https://www.drupal.org/project/we_megamenu/issues/3006302 🐛 Configurations not saving Fixed to 8.x-1.x

You can test to see if this resolved your issue. If so, I can close this issues as a duplicate.

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

@shivam_tiwari - you've just committed the patch file to the repo. That's not a valid way of working.

🇬🇧United Kingdom rjjakes

Merged to 8.x-1.x

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Resolved as part of https://www.drupal.org/project/we_megamenu/issues/3300703 📌 Drupal 10 readiness Fixed

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Both MRs now have conflicts. It's unclear from the thread which MR is correct to merge anyway.

🇬🇧United Kingdom rjjakes

The latest MR now has conflicts that need resolving.

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Merged to 8.x-1.x

🇬🇧United Kingdom rjjakes

Merged to 8.x-1.x
Add commit credit for pookmish

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Merged to 8.x-1.x

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Patch mostly duplicates https://www.drupal.org/project/we_megamenu/issues/3300703 📌 Drupal 10 readiness Fixed

Merged the remaining diff to 8.x-1.x

🇬🇧United Kingdom rjjakes

Patches provided by t1mm1 look the cleanest of the D10/PHP8 patches. I will merge this one and resolve conflicts for others and merge.

🇬🇧United Kingdom rjjakes

Thanks @vpa24 I have pushed your patch.

🇬🇧United Kingdom rjjakes

I've merged the other D9 ticket to 8.x-1.x
I will move toward a formal release after some more testing.

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Merged into 8.x-1.x

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

Done and committed to 8.x-1.x

🇬🇧United Kingdom rjjakes

I would like maintain this module. I have experience maintaining large modules with security coverage.
This module is used internally at my organization so would benefit from commercial sponsorship.

I already have a patched D9 and D10 version available so can quickly move to a release for this.

🇬🇧United Kingdom rjjakes

I made a mess of the MR (reapplied the patch), but cleaned it up and merged to 2.x

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

🇬🇧United Kingdom rjjakes

rjjakes made their first commit to this issue’s fork.

Production build 0.71.5 2024