🇨🇦Canada @metasim

Using MR 17 as patch for version 2.2.6
- the console error goes away
- `open in new window` option is still available

rerolling the patch for 4.2.1

I was able to come across one of the errors seen in screenshot shared by dineshkumarbollu,
Undefined array key `mailkeys_skip` at `reroute_email/src/RerouteEmailHandlerPluginBase.php:152`

Not sure how to recreate it,
My understanding is that we dont have any mailkeys_skip set, so I am getting an error, instead it should skip that part, making use of ?? to patch the same.

I was able to apply this patch for version 1.0.0-rc17
Can confirm the patch applies successfully, and I was able to translate the labels

Adding support for Gin Admin Theme,

The unsaved changes dialog shows up when the Save button is clicked.
This only happens if the Admin Theme is set to Gin, because the Save button exists in the header region and not inside .node-form

Updating the submit button event handling to also check for Save button under gin theme container, if that exists.

Since this fix was implemented for 8.x-1.x-dev and the current version is 3.0.1 there have been a lot of changes with the core of the module, so instead of rerolling the patch, I have created a new way to achieve the same functionality.

My fix allows the user to select between a regular `Dropdown` and `Dropdown with Language Code` under `Widget Look` field.

I have added a new widget type and duplicated/repurposed the dropdown.js to achieve this.

metasim → created an issue.

Thank you, olivier.br
Anyone searching for the issue on media entity module which is actual cause for the above issue can find it here:
Compatibility with Linkit 6 ✨ Compatibility with Linkit 6 Needs work

I had the same error uploading a SCORM package and all this while was trying to find a fix for the opigno_scorm module, but applying this patch solved the error in hand.
Thank you for the patch!

Hello Guys,
I had the same problem with one of my projects,
After trying to find around what the problem might be, I found the same issue on `opigno_module` module which was one of the dependencies in my project.

Applying the patch from this issue here: https://www.drupal.org/project/opigno_module/issues/3377470 🐛 Serialization error when try to upload files into 'File' type fields when create activities Needs review
solved it for me, so this could be helpful for you guys too!

Rerolled the latest patch #32 as it was failing
when applied alongside the D10 and CKE5 readiness issue patch #80,
https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed

@lazzyvn I tested this patch on Drupal core version 9.5.9

The patch applies successfully,
On testing this range slider on a custom form,
There were no errors on console or php.

On submit the range slider returns the values as expected .

So I applied the above patch on D10.1.x-dev to figure out the what might be causing the problem stated by @joaopauloc.dev,

What I found:

For OL:

1. Looks default in the CKEditor UI
2. Looks as per the style selected on node view page

For UL:

1. Shows up with an empty circle in the CKEditor UI instead of a filled black circle as per the toolbar logo
2. Shows up as a filled black circle on node view page irrespective of the style selected

For Styling:

• While inspecting the element and styles applied to it, the li had styles coming from list-style-type property from 2 classes which were set on ol (its parent)
• The 2 classes were .ck-content ol which was applying through the style tag
• and ol which was coming through a css file from /sites/default/files/css
• Turning off the list-style-type properties on both the classes worked and the UI as well as the node view page showed the selected style
• the same was the case with ul > li as well

I am attaching a screen recording of everything I have found and tried out, hopefully it helps!

I tested the patch on D10 and it works as expected,
upgrade status scan clear as well

I tried applying the patch on a fresh D10 install and it applies without any problems.
Also the upgrade status scan was clear on D10 after applying the patch.

@lazzyvn I tried testing the new MR, for some reason the diff.patch still fails on .info.yml file

--- range_slider.info.yml
+++ range_slider.info.yml
@@ -1,5 +1,4 @@
 name: Range Slider
 type: module
 description: Integration with https://rangeslider.js.org
-core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8.8 || ^9 || ^10

After manually changing the core_version_requirement and adding ^10 to it I tested it.
Findings:
Drupal Test Version: 10
Browsers Tested on: Chrome and Firefox

The module seems to work fine on both, see the attached screenshots.

However If you look at the element classes I did not find the class mentioned by you with double dash i.e
js-form-type--range-slider
I found 2 classes namely
js-form-type-range-slider& form-type--range-slider

Based on the screenshots when I click the submit button the value seems to update fine based on the position of the slider.

Created a new MR since the last one is created on the dev branch itself,
So I created one from the issue branch

And the reason it was created is because while testing the previous patch,
i got a twig error on the selectattr() filter, so instead I revised it by removing the if loop outside of the for loop
as per the upgrade_status deprecation notice.

The patch applies successfully, except on the .info.yml file at line #5 on

core_version_requirement

,

range_slider.info.yml.rej:

--- range_slider.info.yml	(revision 7c067925566449a7e7830c746fc3dde7a108ba1a)
+++ range_slider.info.yml	(date 1677972525355)
@@ -2,4 +2,4 @@
 type: module
 description: Integration with https://rangeslider.js.org
 core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8 || ^9 || ^10

Also while testing the patch I get a js error

Uncaught TypeError: $(...).find(...).findOnce is not a function

on `range_slider/js/range-slider.js:59`

The new replacement for the same is once.filter() as per this →

Based on this I think the findOnce() can be replaced with the following line of code by making use of the once.filter()

const filteredElements = once.filter('rangeSlider','.form-type-range-slider input, .js-form-type-range-slider input');
        filteredElements.forEach(function () {
          $(this).rangeslider('destroy');
        })