Allow to add a Drupal core link with Link Widget for Image entities using Entity Embed Dialog in CKEditor

A drawback of the above seems to be that a hyperlinked image continues to be hyperlinked even when rendered inside the wysiwyg editor. A user wouldn't expect that clicking on an element inside the editor would result in linking away from the page.

The new logic within template_preprocess_entity_embed_container perhaps shouldn't fire when embedding inside the wysiwyg.

Patched attached, but possibly there is a better way rather than checking the route.

Oops. Better patch attached.

Rerolled the latest patch #32 as it was failing
when applied alongside the D10 and CKE5 readiness issue patch #80,
https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed

I was able to apply #31 to Entity Embed 1.4.0 and this does seem to eventually solve the "No way to add a link around Image Entities" issue.

However, it might be worth noting that when uploading one's own image, after clicking the 'Add Images' link at the top of the modal, there's an 'Image Link' field within this modal that seems to only exist to allow the user to add a url to the content one thought they were adding in order to have the image link to that specific link entered in that field? (The field is called 'Image Link' but is that really needed if it just prints a url to the image?)

In other words, I'm not 100% clear as to why it's needed? Maybe it was intended to be the link to what the user wanted the uploaded-image to link to? Currently, it just prints that link at the bottom of the image.

But all in all, this patch seems to successfully allow creating an image link as after clicking 'Save Images' at the bottom of that modal, one is correctly taken to the next modal called 'Embed Media Item' where one can properly add an image link (using the 'Link To' field) and that DOES seem to work as intended so thanks for that!

Perhaps this 'Image Link' isn't needed though? Or needs a better description of what it does?

Thanks again for the patch!

Rerolled the patch to be used with https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed with patch https://www.drupal.org/files/issues/2023-03-23/3272732-67-COMPOSER-ONLY-... →

Rerolled the patch to be used with https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed with patch https://www.drupal.org/files/issues/2023-03-23/3272732-67-COMPOSER-ONLY-... →

Add external uri validate

Add autocomplete dependency.