- πͺπͺEstonia hkirsman
this fixed fatal error when doing drush cr
Fatal error: Uncaught Error: Class "Symfony\Component\EventDispatcher\Event" not found in /app/web/modules/contrib/flysystem/src/Event/EnsureEvent.php:10
- π¨π¦Canada metasim
I tried applying the patch on a fresh D10 install and it applies without any problems.
Also the upgrade status scan was clear on D10 after applying the patch. - last update
over 1 year ago 99 pass, 2 fail - last update
over 1 year ago Composer require failure - πͺπͺEstonia hkirsman
The patch also applies to 2.x branch but it's missing core_version_requirement update. I'm confused about how it works for you. I don't see core_version_requirement set for D10 in 3.x branch either.
Bigger issue is that the tests fail but I think it might be something to with Symfony 4 vs 6. I was testing it on Drupal 9.5 locally.
Error:
β Prophecy\Exception\Doubler\MethodNotFoundException: Method `Double\MimeTypesInterface\P12::guess()` is not defined.
I've initiated 2 tests here. One for D9 and the other for D10.
I understand the developers here started 3.x branch but nothing much is done there yet. I guess still the plan is to put new features there. Noticed leage/flysystem version bump here https://git.drupalcode.org/project/flysystem/-/commit/fce77e9882178e64aa...
I do hope that we got also D10 support also for 2.0 and release 2.0.0-beta2 for example. There isn't much to do. Flystem S3 module still requires league/flysystem:^1 so that would be a smoother transition to D10.
- πͺπͺEstonia hkirsman
Tests did fail because of the core_version_requirement:
https://www.drupal.org/pift-ci-job/2654206 βAdding patch
- last update
over 1 year ago Composer require failure - πͺπͺEstonia hkirsman
Tests failed again, so it needs core_version_requirement to already be in the repo?
- last update
over 1 year ago Composer error. Unable to continue. - last update
over 1 year ago 99 pass, 2 fail This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module β , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
- π¨πΏCzech Republic mkolar
Hello guys, how it looks with D10 compatibility? May I help somehow?
- π¬π§United Kingdom Eli-T Manchester
@mkolar do you need to use the 3.x.x branch? Flysystem 2.2.x on Drupal 10.2.x with the patch in π CssCollectionOptimizerLazy and JsCollectionOptimizerLazy use removed inherited member state Needs review seemed ok for us in testing, but we haven't rolled out to production yet.
- Status changed to Closed: outdated
8 months ago 1:51am 8 April 2024 - πΊπΈUnited States lhridley
Closing as the 3.x-dev branch is deprecated in favor of the 3.0.x-dev branch.