🇨🇿Czech Republic @mkolar

hi, what version of the module you using? switch to 9.x-dev@dev.. it should work. we have ho switch to new versioning tho..

mkolar → made their first commit to this issue’s fork.

Hello guys, how it looks with D10 compatibility? May I help somehow?

I merged temporary fix for D10 incompatibility. Work still needed and not use internal library.

mkolar → created an issue.

Any update pls?

info file updated.

mkolar → changed the visibility of the branch 3137588-drupal-9-deprecated to active.

mkolar → changed the visibility of the branch 3137588-drupal-9-deprecated to hidden.

We have this patch for years..

mkolar → made their first commit to this issue’s fork.

If you want, you can proceed with the settings thing + moving it from magic property to entity save completely. It looks better to me now to move it, its already pretty old so cant remember why its in presave. When you have a patch, we will try the patch on our project if its ok. It might take a while. Thank you!

Why you would like to add setting not to index all revisions since module itself doing those flags which needs to be updated? Why you need this module since you only care about default revision then? We can of course add this settings thats easy but not sure how to deactivate those flags if this is turned off. I dont have problem with the settings.

TBH not rly sure why we used search_api_revisions_update_ids and not doing it in entity_udpate hook (since we made that hook too) but i bet there was some good reason. What might be one of the reasons is that like this, its alterable by another module (but we are not doing this). But since its not improving anything why to change this, whats the reason.

Hi. We have to test this. Im not 100% sure now but I think it’s due flags like is default revision and is last revision. Especially in case you have published revision which is not last (published article with new unpublished drafts for example). We have few millions of revisions with no performance problem (module needs to reindex in the queue).

mkolar → made their first commit to this issue’s fork.

Hi, is there any update? Module code seems compatible (upgrade status says) can we merge this and make a release? Thank you!

Hi, is there any update? Module code seems compatible (upgrade status says) can we merge this and make a release? Thank you!

mkolar → created an issue.

I added you as co-maintainer.

LGTM

Hi! patch #9 works for me, before patch we had problem with API exactly like @apmsooner. RTBC! TY!

also thanks @apmsooner for posting that error here, we found this patch thanks to it!