Tests are failing
@cmlara could we please have a new tagged release? Thanks!
#15 Thanks, will do
baikho → changed the visibility of the branch 3517986-entity-finder-plugin to hidden.
Woops wrong module :)
baikho → created an issue.
I tested patch from #18 on v3.0.0, but that is still reproducing the behaviour described as in #6
But the first imported german node is gone, and was replacing through the english version.
Or what I think is happening is that the original source node's language get swapped with the overridden language instead.
Just adding my two cents — I think the solution in ✨ Support Batch Processing Active could serve as an example for implementing something similar for JSON:API.
And then there is also https://www.drupal.org/project/feeds_paged_drupal_jsonapi_fetcher → , although it looks quite outdated.
Tested MR !174 on 3 custom Feeds Importers that extend the BaseItem class.
- Drupal Core 11.1.3
- PHP 8.3.15
- Feeds v3.0.0
Works as expected and no PHP deprecation notices now. RTBC for me
Thanks for the swift response!
I don't have permissions to do so, so I'm assigning this to you @shadcn
baikho → created an issue.
Not sure why #6 was closed, this is still an issue on 3.0.x-dev too
And patch, for both 1.0.0-beta1 and 1.0.x-dev
Usage example of this change:
$configuration = [
'http_client_options' => [
'timeout' => 300,
],
];
/** @var \Drupal\ai\Plugin\ProviderProxy $provider */
$provider = $this->aiProviderPluginManager->createInstance($providerChoice, $configuration);
And a patch on beta1
I believe this could be considered a bug
Currently only supports Media images.
#12 Thank you for testing!
Let's put these changes in a Merge Request, so that the pipeline tests it on D11 too.
Tests have meanwhile been added in #3202448: Test basic use case of excluding node types → and are also running on Gitlab CI now. Other tests are being rolled out as we go, see for example 🐛 Changing exclude criteria and reindexing does not remove newly excluded nodes from search index Needs review .
On second thought, as we hadn't need to drop support for older Core versions in 📌 Automated Drupal 11 compatibility fixes for search_exclude Needs review , I think we can just stay on 3.0.0 for a RC1.
Your patch and Merge Request don't hold the pending changes of 🐛 Route does not exist Active which is why I think you ran into that error. Please see that issue and the updated patch.
In the meantime, adding a new patch from the MR and so that people don't run into 🐛 Error Class Url Not Found to Edit search page Content(exclude) Needs review .
Thanks for all the help and feedback everyone. However I believe there are 2 things worth pointing out:
1. Whilst testing this, I found that the redirect to the entity collection page would discard the Configuration form's confirmation message, which makes it unclear if the form had been successfully saved.
2. There is
🐛
Cannot find route error
Active
, which is this very same bug report but on the former 2.x branch, and I think this more of a Core bug rather than this module at fault.
I'm closing this with it being worked at in
🐛
Route does not exist
Active
on the supported 3.x branch. Also bearing in mind that I still believe this to be a Core bug as per #10.
Happy for the pipeline to include the DrupalPractice standard and READMEs.
As a bonus, I have corrected the spelling error (UK -> US) so that job is green now.
I'm happy to help with setting up the phpcs.xml file if you want, depending on your views of the two points in #5
Thanks for those fixes already, gladly have your help on these. I'll try and find some time to fix the descriptions.
Merged now, thanks for the help!
Looking at the build https://git.drupalcode.org/project/faker/-/pipelines/420180 now, I think I understand what you were referring to with #6 now. As it shouldn't be able to install with composer when not compatible w/ D11, yet it was able to.
Hmm I can't seem to disable the current composer job. (Trying to have it run on D10 only for now)