🇧🇪Belgium @baikho

This still doesn't work for me.

When I make changes and switch from 8.x-2.0 to 2.0.0-alpha2, I get:

drush status
Error: Class "Drupal\site_settings\SiteSettingsLoader" not found in Drupal\Component\DependencyInjection\Container->createService() (line 259 of /var/www/html/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php).
 [warning] Drush command terminated abnormally.

So I run cache clear to clear that error, but then subsequently I cannot run any drush command, incl.:

drush cr

In DiscoveryTrait.php line 53:
                                                                                                                                
  The "" plugin does not exist. Valid plugin IDs for Drupal\site_settings\SiteSettingsLoaderPluginManager are: flattened, full  

Or the update hook as per #8:

drush php-eval "\Drupal::moduleHandler()->loadInclude('site_settings', 'install'); site_settings_update_10004();"

In DiscoveryTrait.php line 53:
                                                                                                                                
  The "" plugin does not exist. Valid plugin IDs for Drupal\site_settings\SiteSettingsLoaderPluginManager are: flattened, full  

Or configuration set:

drush cset site_settings.config loader_plugin 'flattened'

In DiscoveryTrait.php line 53:
                                                                                                                                
  The "" plugin does not exist. Valid plugin IDs for Drupal\site_settings\SiteSettingsLoaderPluginManager are: flattened, full  

It only works when I execute the above cmd ahead of checking out the 2.x codebase.

drush cset site_settings.config loader_plugin 'flattened'

 loader_plugin key does not exist in site_settings.config config. Do you want to create a new config key? (yes/no) [yes]:
 > yes

Couldn't apply patch from #4, so re-adding

Clearing cache resolved this for me.

The fix is failing on 10.1.x, so moving back to Needs work.

If we can't ensure compatibility for both 10.1.x and 10.2.x, then we may need to introduce a new release with updated version constraints or so.

Thanks for raising this. It seems the parent Validator class introduced these changes in Drupal 10.2.x via 📌 UniqueFieldValueValidator works only with single value fields Fixed causing the breakage.

+1 for this, as facing issues with the new widget structure in 🐛 Errors after upgrading to 3.0.1 from 1.14 or 1.15 Needs work . Adding patch from fork

Adding a patch we have been using on Acquia

baikho → created an issue.

baikho → created an issue.

Tested and works fine

Someone who is more familiar with the module could adjust the docs to clarify how to use this module add CSRF token protection to form routes which are registered by core or other modules (or whether this is even possible).

For existing routes, you will need to form alter and call the CSRF token service manually for both generating and validating the tokens. Alternatively, please refer to the 8.x-1.x project page details for the Drupal 7 approach in Drupal 8+.

Specifically, it's not clear to me how to do this step

I have updated the developer instructions now on the project page.

Branch 2.x will be made D10 compatible, see 📌 Automated Drupal 10 compatibility fixes Needs review

baikho → made their first commit to this issue’s fork.

Thanks all, I'm adding a new major version branch, given the Core deprecations.

I manually tested updated Merge request !4, but it doesn't work and the slider doesn't render. In the meantime I'm going to take the changes only needed for D10 compatibility, please raise the other changes in a new issue as they need more work. Thank you

#2If you uninstall locale (drush pmu locale) you will have the empty form in your case. I have added the reproducible steps in the issue summary, thanks

Thank you!

Thanks!

baikho → created an issue.

@baikho thanks for maintaining this module well. I have query there is any timeline when we are able to see stable version of range_slider for drupal 10?

#21, once my review remarks in Merge request !4 have been resolved. Thank you

Improved formatting

#8 Looks interesting. I'll read up on it, thanks!

Just noticed that the test uses the wrong Plugin Provider as string webform_pardot_handler, which should be webform_pardot so this needs an additional fix PardotHandler::getPardotFieldsValue() and the test.

Based on #5, I'm updating Issue summary with some additional tasks.

#19 Thanks for clarifying.

Sorry, I see now that the selector in patch #13 is correct, I was looking at Merge request 4 https://git.drupalcode.org/project/range_slider/-/merge_requests/4#note_.... I'll update the MR accordingly.

Let's proceed in linked issue, thank you.

Sorry but the tests are still failing, so this can't be merged yet.

Please apply changes onto a Merge Request as a Patch will fail to apply as you can see in #3 and #13.

Could a new fork be created from the 2.0.x branch? This will likely solve the test composer error. 1.0.x is no longer maintained.

Thank you

Crediting contributions in linked 🐛 Submission is stuck in queued Closed: outdated

Thanks all, this is fixed in 🐛 Submission is getting stucked in queued Fixed

baikho → created an issue.

Updating tests

Tested MR in #4 and the Webform Submission reference is still intact. RTBC

Thanks all for your work on this. Could we please apply the changes via a fork merge request to ensure the tests run?

Moving back to "Needs work" as per #4.

I use this module on a few projects, and would like to help maintain this module.

Closing for now, feel free to re-open.

Just adding rerolled patch from #109 against 8.8.x, but without the Media changes from #115.