Antwerp, BE
Account created on 16 October 2013, almost 12 years ago
  • Drupal Developer at iO  …
#

Merge Requests

More

Recent comments

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → made their first commit to this issue’s fork.

🇧🇪Belgium baikho Antwerp, BE

My bad. The error occurs at json_decode() (line 59), before any of our processing logic runs. This confirms the raw JSON response data is too large and not the parser at fault.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE

baikho → made their first commit to this issue’s fork.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

@orkut murat yılmaz yes, but we need one for Project Browser →

🇧🇪Belgium baikho Antwerp, BE

Updated code example

🇧🇪Belgium baikho Antwerp, BE

Added relevant module to related content

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

I've added relevant changes together in MR 19 from ✨ GUI of regex_redirect does not support targets without a pattern Active that allows for all languages applied on a redirect.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

@majid.ali Thanks for the fix!

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE

Looking at this again and I can understand why, but am reluctant to add this in a minor or patch release as I believe it could break existing installations in terms of styling. I think we need some more review, testing and thoughts on this.

🇧🇪Belgium baikho Antwerp, BE

Sorry for the delay and thanks for the details so far, but I would need a little bit more steps to reproduce.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

I appreciate this is an old bug report but tested both on latest 2.x and 3.x with Ajax on Webform without issues. If this is still happening please feel free to re-open.

🇧🇪Belgium baikho Antwerp, BE

Sorry I didn’t get back on this but it would have to be an extended functionality on the form element and the field widget / Webform depending on where you want it.

However given the underlying library being archived, I suggest this to be looked at in 3.x of this module.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

#3

@rajveergang the module uses the current node as a parent for a new node that will be created, hence it doesn't make sense to add an operation link in admin/content. You can add a child page while editing or viewing a node, and the idea is that you don't need to go down the menu links, you can add a children to the current node.

Please see ✨ Add dropbutton in Content overview Active . This approach has been working well for our client, though I understand it may not align exactly with the direction you envision for the project moving forward.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

Sounds like a good feature

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE

After testing, I think we should still support target URLs using the internal schema when the named capture is omitted. This would make it easier to use and ensure the redirect continues to work if the target path changes.

🇧🇪Belgium baikho Antwerp, BE

Tried to backmerge 2.0.x for the MR patch to update but somehow it shows a whole different diff yet https://git.drupalcode.org/project/regex_redirect/-/merge_requests/12.patch

So instead manually adding patch from MR 12

🇧🇪Belgium baikho Antwerp, BE

baikho → made their first commit to this issue’s fork.

🇧🇪Belgium baikho Antwerp, BE

More work is needed to convert tests

🇧🇪Belgium baikho Antwerp, BE

baikho → made their first commit to this issue’s fork.

🇧🇪Belgium baikho Antwerp, BE

Keeping it as a procedural hook_entity_operation implementation for BC with D10

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE
🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE

baikho → made their first commit to this issue’s fork.

🇧🇪Belgium baikho Antwerp, BE

Yes, at the moment you’d either need to fork the GitHub repository and build the JS bundle with translatable strings, or implement a proxy endpoint in Drupal that serves translated data. I’m happy to review merge requests if someone would like to contribute an alternative implementation.

🇧🇪Belgium baikho Antwerp, BE

Follow up issue here 📌 Fix PHPStan violations Active for phpstan corrections after the merge.

🇧🇪Belgium baikho Antwerp, BE

baikho → created an issue.

🇧🇪Belgium baikho Antwerp, BE

Also tested this and it works fine. If someone else could also review and move to RTBC please.

🇧🇪Belgium baikho Antwerp, BE

baikho → made their first commit to this issue’s fork.

Production build 0.71.5 2024