- First commit to issue fork.
- ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
Patch #4 works great for me as well. RTBC ++
Thanks for the work.
- @urvashi_vora opened merge request.
- ๐น๐ทTurkey kburakozdemir ฤฐstanbul
Thanks for the work.
Patch #4 works great for me as well.
- ๐ง๐ชBelgium kriboogh
This is a 5 year old patch that multiple people have mentioned works.
What is holding it back to get it in the next release ? - last update
about 1 year ago 49 pass - ๐จ๐ญSwitzerland berdir Switzerland
Re #12:
It would need to be within the loop, but as commented by others, there are cases where aliases still need to be updated even if the translation didn't change, so I suppose not much can be done about that.
#28: The performance concerns, mostly.
This might hurt sites with a lot of languages quite a bit. There are now 3 places with this loop, the first one is in bulk generate. Also, we have issues like #2946354: Alias not using language undefined when alias is not translatable โ with the goal of supporting language-neutral aliases. This change is going to make that more complicated because then we'd call it multiple times but really will always create/update the same alias. So this loop should possibly be within updateEntityAlias(), after checking the language setting of the field and depending on that once the other issue lands.
- ๐ง๐ชBelgium RandalV
Thanks for the patch/MR.
I've applied the MR diff to one of our sites, and the issue has been resolved.Hopefully this finds its way into a release ๐