Node data stays in index after node is deleted

Here's a fail test and a fix.

The approach in the IS didn't quite pan out because `searchIndex` is protected. Instead I followed the code in the Node class very closely. Seems to work!

This would not clear out data for previously deleted nodes though. That could happen in an update hook, but I don't have the energy for that at the moment.

Also note that the new test coverage here conflicts with the new test coverage in another issue I worked on: 🐛 Changing exclude criteria and reindexing does not remove newly excluded nodes from search index Needs review

I think that issue is more important so I'd like to see that fixed first. Then this patch could be rerolled.

The last submitted patch, 2: search_exclude-node-delete-3356664-2-FAIL.patch, failed testing. View results →

My team also ran into this issue. The patch worked perfectly for us.

We also ran a node_update_N() to clear nodes from the index that we had already deleted (we only had a handful of nodes). This might be helpful for others:

function my_module_update_N(&$sandbox) {
  $nids = [...]; // Your list of nodes.

  $search_index = \Drupal::service('search.index');

  foreach ($nids as $nid) {
    $search_index->clear('search_exclude_node_search', $nid);
  }
}