Contrib.social

Refactor Core Node Access Tests to not only test for denies, also test for public grants

Open on Drupal.org →
Created on 27 March 2013, over 12 years ago
Updated 17 January 2025, 6 months ago

Follow up for 1. in #1658846-187: Add language support to node access grants and records →

Problem/Motivation

Missing test coverage for grants. We only have tests for denies.

Proposed resolution

Add more coverage for the case where there are actually explicit "public" grant records written from another module.

Remaining tasks

  • (optional) Check this issue summary for accuracy
  • (optional) Add some details to make this able to be picked up by someone new
  • Add the tests. See contributor task document for writing tests: http://drupal.org/node/1468170

User interface changes

No UI changes.

API changes

No API changes.

Original report by @xjm

We agreed earlier:
2. Add more coverage for the case where there are actually explicit "public" grant records written from another module or write a follow-up issue.

Fully agree, but as this is not yet covered currently I think we can make a follow up Issue: "Refactor Core Node Access Tests to not only test for denies, also test for public grants"

Let's file this and link it here.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

node system

Created by

🇺🇸United States yesct

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 6 months ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Status changed to Closed: outdated 3 months ago
  • Comment 3 months ago →
    🇦🇺Australia acbramley

    Taking a look at what we currently have I think this can be closed. There's very thorough testing around node access and languages in NodeAccessLanguageAwareTest, NodeAccessLanguageAwareCombinationTest, NodeAccessLanguageTest, etc.

  • Status changed to Postponed: needs info 3 days ago
  • Comment 3 days ago →
    🇺🇸United States xjm

    @acbramley, are you sure? This was a followup from the issue that added those tests, specifically. Did we add test coverage for the specific cases listed in the IS since I first identified the deficiency with the tests back then? :)

  • Comment 3 days ago →
    🇦🇺Australia acbramley

    @xjm just looking at one example I listed in #15 - https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/node/... this looks to me to be testing both grants and denies.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024