#Node access

Was going to assign it to myself to explain later but then ended up explaining it now.

The code is still essentially the same, so I should probably try to determine what I was talking about in my review of [#7173848-187]. The problem that I believe I was talking about was the following codepath:

if (isset($grant['langcode'])) {
        $grant_languages = array($grant['langcode'] => language_load($grant['langcode']));
 }

...in the scenario where the Language module or the language in question was not available.

language_load() not defined ➡️ fatal. This potential problem goes away with post-release Drupal 8 now that the language manager is always available.

Language not currently available on site ➡️ an array [$langcode => NULL]. Then the foreach would set it to a null langcode. That's the part I was asking for test coverage for, because this could potentially cause strange things for site owner expectations if a language is disabled and then re-enabled, for exampled.

They're still there and haven't been clarified. :)

@xjm just looking at one example I listed in #15 - https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/node/... this looks to me to be testing both grants and denies.

@acbramley, are you sure? This was a followup from the issue that added those tests, specifically. Did we add test coverage for the specific cases listed in the IS since I first identified the deficiency with the tests back then? :)

xjm → changed the visibility of the branch 3061782-add-langcode-from to hidden.

Setting active and hiding the previous patches since we can't really build on that approach. Thanks!

This does sound like a bug.

That said, the current patch, which couples the node grant storage to the views API, is a non-starter. I think this would be more properly fixed in the node views handlers somewhere.