- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 1:26pm 11 September 2023 - last update
about 1 year ago 26,612 pass, 2 fail - last update
about 1 year ago 27,287 pass, 2 fail - π³π±Netherlands timohuisman Leiden, Netherlands
Re-roll #116 against 10.1.x and 11.x. The custom commands failure from #116 should have been fixed.
The last submitted patch, 118: 2454289-118-10.1.x.patch, failed testing. View results β
The last submitted patch, 118: 2454289-118-11.x.patch, failed testing. View results β
- Status changed to Needs work
5 months ago 11:14am 3 July 2024 - π¬π§United Kingdom nicrodgers Monmouthshire, UK
I've re-read through every comment in this issue and have observed the following:
data-drupal-link-system-path
in #4, @nod said
li element shouldn't have the data-drupal-link-system-path either.
in #94, @andrewmacpherson said
What's going on with the
<li data-drupal-link-system-path>
attribute? In #4, _nod suggested removing it from the list item. It's still there though. It looks like an earlier patch (#26) removed it, but by patch #82 it's come back.This hasn't been addressed, so we need to decide whether this is something that needs to be done here or not, and update the issue summary and description accordingly.
data-drupal-language
in #94 @andrewmacpherson also said
The new data-drupal-language attribute isn't very well explained.
and this hasn't been addressed yet either.
failing tests in #118 need addressing
needs re-rolling
- π¬π§United Kingdom jonnyhocks
Here's the re-rolls for 10.3.x and 11.x - both based on #118 π Attribute hreflang not allowed on element li at this point Needs review
The other items from #121 π Attribute hreflang not allowed on element li at this point Needs review remain outstanding.