The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 5:43pm 15 February 2023 - Status changed to Needs work
over 1 year ago 5:41pm 20 February 2023 - Status changed to Needs review
over 1 year ago 4:58am 23 February 2023 - 🇮🇳India Krishnapal singh21
Uploading patch after fixing custom command failure
- Status changed to Needs work
over 1 year ago 7:57am 23 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India sahil.goyal
I noticed that the error pattern #^Variable \$form_output in empty\(\) always exists and is not falsy\.$# is being ignored in the file /var/www/html/core/modules/system/tests/src/Functional/Form/FormTest.php. I understand that this is a false positive caused by the Drupal FormTestBase class. This class includes a method called assertEmpty(), which checks that a variable is both empty and not falsey.
- @bhanu951 opened merge request.
- 🇮🇳India Bhanu951
Rerolled 2512466-83.patch against 10.1.x and updated dictionary.txt file.
- Status changed to Needs review
about 1 year ago 11:06am 2 April 2023 - Status changed to Needs work
about 1 year ago 6:34pm 5 April 2023 - First commit to issue fork.
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 29,332 pass, 6 fail - last update
about 1 year ago 29,348 pass, 2 fail - last update
about 1 year ago 29,373 pass - Status changed to Needs review
about 1 year ago 9:49am 3 May 2023 - Status changed to Needs work
about 1 year ago 6:02pm 5 May 2023 - 🇺🇸United States smustgrave
Glancing at the issue summary and seem it could use a little love.
Specifically what is the proposed solution.
Testing steps still the same?Not 100% sure if the new function for the FormElement may need a change record.
- last update
12 months ago 29,501 pass