Language class should use property 'label' to be consistent with entities

Created on 21 April 2014, over 10 years ago
Updated 4 January 2025, 16 days ago

Problem/Motivation

Although Language is not an entity, it almost shares a structure with ConfigurableLanguage and that uses label (just as other entities do).

Beta phase evaluation

<!--Uncomment the relevant rows for the issue. -->

Postponed for 8.1.x because it does not meet the qualification on https://www.drupal.org/core/beta-changes β†’ ?

Proposed resolution

  • In core/lib/Drupal/Core/Language/Language.php change name to label to be consistent.
  • Update all uses.
  • Keep old function names as a BC wrapper.
  • Need a follow up issue postponed until 8.1.x. to remove the deprecated methods.

Remaining tasks

<!-- Delete or add (novice) from the tasks below as appropriate. uncomment tasks as the issue advances. add (done) to indicate when they are done, and maybe reference the comment number were they were done. -->
  • git instructions for creating patch | Contributor task documentation for creating a patch
  • perform patch reroll
  • Review patch to check it fixes the issue, the change is properly documented and for coding standards. Make sure patch stays within scope of just this issue. | Contributor task documentaiton for reviewing patch
  • <!-- <li>Update issue summary | <a href="https://drupal.org/contributor-tasks/write-issue-summary">Contributor task documentation for updating issue summary</a></li> -->
  • Update the issue summary noting if allowed during the beta Instructions β†’
  • <!-- <li>Add automated tests | <a href="https://drupal.org/contributor-tasks/write-tests">Contributor task document for writing automated tests</a> --><!-- <li>(novice) Backport | <a href="https://drupal.org/contributor-tasks/backport">Contributor task document for backporting a patch</a></li> --><!-- <li>Draft a change record | <a href="https://drupal.org/contributor-tasks/draft-change-record">Contributor task document for writing a change record</a></li> --><!-- <li>(novice) Improve documentation or standards (for just lines changed by the patch) | <a href="https://drupal.org/contributor-tasks/improve-patch-standards">Contributor task document for improving documentation or standards in a patch</a><li> --><!-- <li>(novice) Manual testing | <a href="https://drupal.org/contributor-tasks/manual-testing">Contributor task document for manual testing</a></li> --><!-- <li>(novice) Steps to reproduce | <a href="https://drupal.org/contributor-tasks/add-steps-to-reproduce">Contributor task document for adding steps to reproduce</a></li> --><!-- <li>(novice) Embed before and after screenshots in the issue summary | <a href="https://drupal.org/contributor-tasks/manual-testing">Contributor task document for adding screenshots</a></li> --><!-- <li>(novice) Accessibility testing | <a href="https://drupal.org/contributor-tasks/accessibility-review">Contributor task document for manual accessibility testing</a></li> -->

User interface changes

No

API changes

No

Related issues

πŸ“Œ Task
Status

Closed: won't fix

Version

11.0 πŸ”₯

Component

language.module

Created by

πŸ‡ΊπŸ‡ΈUnited States yesct

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    It's been 10 years without interest in this issue, so I'm just going ahead and won't fixing a few old issues that haven't been touched.

Production build 0.71.5 2024