Contrib.social

Improve how field definitions deal with dependencies and testing

Open on Drupal.org →
Created on 25 November 2013, over 11 years ago
Updated 7 March 2025, about 2 months ago

#2047229: Make use of classes for entity field and data definitions → introduced field definitions as objects. Those objects make use of some services, but do not have any dependencies injected right now. So we might find ways to improve testability with the current way of doing things, or use injected dependencies and implement __sleep() (which would require benchmarks).

#2047229-108: Make use of classes for entity field and data definitions → tried to use that but ran into problems with stale references during some tests:

+  /**
+   * Returns the typed data manager service.
+   *
+   * @return \Drupal\Core\TypedData\TypedDataManager
+   *   The typed data manager.
+   *
+   * @see \Drupal::typedData()
+   */
+  public static function typedData() {
+    if (!isset(static::$typedData)) {
+      static::$typedData = \Drupal::typedData();
+    }
+    return static::$typedData;
+  }

This probably depends on how we'd like to move on with #2116341: Apply defaults to definition objects → .

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

field system

Created by

🇦🇹Austria fago Vienna

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024