Contrib.social

Calling ContentEntity::updateOriginalValues() should not be the task of the SqlContentEntityStorage

Open on Drupal.org →
Created on 10 October 2014, over 10 years ago
Updated 14 April 2025, 8 days ago

ContentEntityBase::updateOriginalValues() is about internal housekeeping (syncing the FieldItemList values back into the "raw" values). It is currently only called by SqlContentEntityStorage::save().

Not sure why we need to do that housekeeping specifically at save time, but:
- why is this done in SqlContentEntityStorage specifically instead of ContentEntityStorageBase ?
- it doesn't feel right that the Storage is in charge of triggering that internal housekeeping ? The fact that ContentEntityBase has internal, protected $fields and $values properties that need to be synced is of no concern to the storage ?
- for that matter, updateOriginalValues() is not part of ContentEntityInterface, and so is not somehing that the storages should be able to call ?

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

entity system

Created by

🇫🇷France yched

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 8 days ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024