Contrib.social

Remove usages of FieldItem::applyDefaultValue()

Open on Drupal.org →
Created on 14 October 2014, over 10 years ago
Updated 15 April 2025, about 1 month ago

Followup for #2164601: Stop auto-creating FieldItems on mere reading of $entity->field[N] → .

Patch over there has this in FieldItemList::applyDefaultValue() :

if (no default value is specified for the field) {
  // Create one field item and give it a chance to apply its defaults.
  // Remove it if this ended up doing nothing...
  $item = $this->first() ?: $this->appendItem();
  $item->applyDefaultValue(FALSE);
  $this->filterEmptyItems();
}

Having to create an item in case it wants to set a value is absurd. Field types that need this have other ways:
- use the 'default_value' annotation for the field type added by #2318605: uuid, created, changed, language default value implementations need to be updated →
- implement FieldItemList::processDefaultValue(),
- override FieldItemList::applyDefaultValue() itself

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

field system

Created by

🇫🇷France yched

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 month ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Comment about 1 month ago →
    🇷🇴Romania amateescu

    This is still a valid problem :)

  • Comment about 1 month ago →
    🇺🇸United States smustgrave

    Thank you for following up!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024