- Issue created by @Kartagis
- Merge request !9839Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for... → (Open) created by Kartagis
- 🇹🇷Turkey Kartagis Istanbul
kartagis → changed the visibility of the branch 11.0.x to hidden.
- 🇹🇷Turkey Kartagis Istanbul
kartagis → changed the visibility of the branch 3480761-grammatical-mistake to hidden.
- 🇳🇱Netherlands Lendude Amsterdam
Discussed in #bugsmash with @longwave and @smustgrave and we agreed that dropping the 'Should' from the wording entirely would probably make this clearer, so something like "Use replacement tokens from the first row" and the last one "Display on empty results".
Other opinions?
- 🇮🇳India sayan_k_dutta
Looks good on removing the 'should' wording entirely and instead make the texts like "Use replacement tokens from the first row?". Should I make the changes?
- First commit to issue fork.
- 🇮🇳India shalini_jha
I have fixed the pipeline failure issue. Also, the last point mentioned in #9 makes more sense, so I have updated the views_area label. Moving this to 'Needs Review'. Kindly review.
- 🇮🇳India shalini_jha
Addressed the feedback regarding grammatical issues. The pipeline has passed, so I'm moving this to 'Needs Review.Kindly review.
- 🇺🇸United States smustgrave
@kartagis anyone who helped address or move the issue along gets credit if that's what you're asking.
Feedback appears addressed
- First commit to issue fork.
- 🇱🇰Sri Lanka isururaveen
I am working on this issue on DruaplCon Singapore Contribution Day
- 🇮🇳India sumeshsr
Working on this issue with @isururaveen on #DrupalConSingapore2024
- 🇮🇳India shalini_jha
@sumeshsr AS discussed with you, i have checked the pipeline failure , it is just a random failure , you can fix this by re-run pipeline or re run failed job. it will fix.
- 🇮🇳India anmolgoyal74
Used the former suggestion to keep the same label: "Display even if view has no result".
I did it as a part of contribution sprint at DrupalCon Singapore 2024. - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 11.x
No backport because this is a string change and will impact translations. Tagging as such.Thanks folks. It was nice to meet you in Singapore @anmolgoyal74!
- Status changed to Fixed
4 months ago 12:25am 19 December 2024 -
larowlan →
committed e1d70dda on 11.x
Issue #3480761 by kartagis, shalini_jha, anmolgoyal74: Grammatical...
-
larowlan →
committed e1d70dda on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.
