🇮🇳India @debrup

I am currently working on this issue.

Reviewed the issue.

• Reproduced the issue in Drupal 11.1.6 with this fork installed.
• After reproduction of the issue, applied MR580 to fix the issue.
• Changes worked as expected.

Attaching a video for more clarity.
Moving the issue to RTBC.

I have tested the fix in a Drupal 11.1.6 site.

• Reproduced the issue first by activating force color in browser.
• Applied MR579 to apply the fix.
• Confirmed that the patch was working. No double caret found in select elements across the site after activating forced colors in the browser.
• Checked that the fix also worked for light mode with forced colors active.

Attaching ss of the fixed dropdown for better clarity. Moving the issue to RTBC.

@adamps I have created a new user set to a non-default language. When their account gets created the mail is sent with the corresponding template in the langcode set for that user.

Updated the image as requested by @tirupati_singh

• Added spacing from top and bottom while maintaining aspect ratio of the image.
• Renamed the file to "logo.png".

Please review the changes.

I was testing this issue as mentioned by @adamps.

• Set up a multilingual site with a user configured with a non-default language.
• Used hook_mail() and mail() method to send mail during user creation (for using LegacyEMailBuilder).
• However the correct language template is being sent to the receiver even without the fix based on the user's langcode.

Am I doing it correctly? If not, then mention where and how the error occurs and how to reproduce it. Any help is appreciated. Thanks in advance :)

The changes look good to me. Installed the module and did some manual testing. Working as expected with no errors.

@bbrala Please check the recent changes and merge.

Successfully reproduced the issue and applied changes to fix the issue. Checked Drupal upgrade status' module warning and made sure it got fixed after applying the changes.

Drupal version: 10.4.5
Upgrade status (contrib) version: 4.3.6
JS cookies (contrib) version: 1.0.1
Fast Permissions Administration version (used for error reproduction): 4.0.1

Looks good to me. Moving the issue to RTBC.

Could not reproduce the issue @agbockus and @shivam_tiwari.

Drupal version used: 10.4.5
FPA module version used (for reproducing error): 4.0.1 and 4.0.x

Hello @loze,

I have applied the MR and the image style gets added on the tag image as desired. Attached some screenshots with this comment.

Moving the issue to RTBC.

Will try to implement this.

Hello @sourabhsisodia_,
I was going through the codebase for reviewing and found many areas where depends key is still being used. I think we should change them as we are already deprecating the depends key.

Places still using the 'depends' key which I found (could be more):-

• src/Importer.php
• tests/modules/default_content_test_yaml/content/node/*
• tests/src/Kernel/ExporterIntegrationTest.php
• tests/src/Kernel/MenuLinkContentNormalizerTest.php
• tests/src/Kernel/ParagraphNormalizerTest.php

Moving the issue to NW.

I have checked the MR. The fix works and the warning is no longer showing.
Drupal version used: Drupal 11.0.0
Checked Fancytree library by using both CDN and composer install.

Moving the issue to RTBC.

Hello @davidburns,

This is the logo of the module which I modified to match the requirements of the project browser logo. Followed all the recommended steps in the documentation. Please check if this logo is suitable and let me know if any changes are required or not.

Thanks @shivam_tiwari for the changes.

I have reviewed the MR and it is working perfectly in drupal11 site. It has fixed the compatibility issue with Drupal 11.

Moving the issue to RTBC :)

Working on it.

I have reviewed the changes. The fix is working as expected, due to the role attribute being successfully removed from the ul tags.

The test was performed on a Drupal 11.1.1 site.Attached some screenshots of the final markups.

Moving the issue to RTBC.

I have reviewed the MR and it is working perfectly in drupal11 site. It has fixed the compatibility issue with Drupal 11.

However, the changes should have been done in 3434353-automated-drupal-11 branch instead of the project-update-bot-only branch as given in the bot instructions.

@shivam_tiwari Please make the changes in the 3434353-automated-drupal-11 branch and raise a new MR from that branch.

Moving the issue to Needs Work state.

I have fixed the issue as mentioned in #16. Please review it @tonypaulbarker :)

Hello @rkoller,
I was using a forked repo of the 1.x branch as I was working on an issue. The fork is fairly new as I created it yesterday. I did not use any zip file.

I ran into same error while installing the site with the installer. But WSOD appears with only a line at first:

The "dashboard" parameter was not converted for the path "/admin/dashboard/{dashboard}" (route name: "entity.dashboard.canonical")

After refresh, the same complete verbose is shown as mentioned in the issue-summary.

But this error occured for me with two browsers (both chromium based):

• Microsoft Edge version: 131.0.2903.99
• Brave: version version: 1.73.101

However the error DOES NOT occur in Mozilla Firefox 133.0.3 (64-bit)! It worked perfectly in this browser!

Some more info about the testing environment:
OS: Ubuntu 24.02
ddev: 1.24.1

Same process was applied. None of the pre configured content types were selected and skip this step button was pressed followed by regular install with default name.

Hello @tonypaulbarker, @pameeela,

I have created a new image style named "Media Library Square Thumbnail" with focal point scale and crop effect and webp conversion effect. Applied this new style to the media library.

Please review this and let me know if it works.

Hello @michael.garrido, I will try to see if it is possible if I get the time to experiment. But then this issue may get more closer to a "Feature Request" rather than a "Bug Report". Also the changes to be made will act upon core and paragraph functionality albeit through hook implementation. Plus I think the collapse button will require some serious work to achieve what you want (through Javascript).

Working on it.

Hello @michael.garrido,
After a lot of researching I found the main issue is with the paragraphs module and how Drupal does validations by default.

Whenever a required field is empty or NULL, Drupal Core does not allow the creator to save or preview the node.
Similarly for paragraphs module, it does not allow any required field to be empty when we are saving or previewing the node or when we try to collapse the field.

I confirmed this behavior by experimenting with a text field only. There also if the text field was set as required and left empty it will not allow me to collapse the field. Consequently it showed the same "This value should not be null" error.

Similarly for the media field, unless an until we enter the values and Create the media, the paragraph field is not getting any reference to the media entity. So essentially it is seeing it as a null value in the entity reference field as there is no reference to any entity.

There is a possible workaround but it is dangerous as it skips the validation process which can cause errors down the line and affect the references which can possibly throw exceptions. However I will suggest some ways to prevent this error.

• Always create the media before collapsing the field or previewing the node.
• Make the Media field non-required. This method should be used wisely as the collapsed media is not yet saved and if it is collapsed then data loss may happen and still it has to be created before saving the node.

Its all I can do for now. Let me know about my analysis and if it is satisfactory or not or in case of any doubts. I will be unassigning myself from the issue for now.

Hello @michael.garrido, sorry for the delay in response as I was busy. I was able to reproduce the aforementioned issue successfully. Thank you for providing the revamped instructions. I will be trying to fix the issue.

Hi @michael.garrido, just to clarify, are we creating the new media by clicking the "create new media" button before clicking the collapse or preview button?

@michael.garrido I still cannot reproduce the error. Please reproduce it from your end again and generate new instructions.

@stephencamilo after applying your patch shows the dependencies in Drupal module list. However, the module does not install until all dependencies are downloaded to the drupal site manually through composer. Is this the behavior you want?

Or, do you want composer to automatically download all the dependencies when we require the entity browser module, along with defining the dependencies in the info.yml file for installing the dependent modules when installing the entity browser module?

I have fixed the above issues. Please review.

@djsagar Thank you for working on this issue and removing the "!important" from the code as it is not an ideal solution.
I have reviewed the code and it is working as expected. However I found some issues with the code which I will be listing below:

- Code has been repeated multiple times. I think it should be avoided for maintaining clean code.
- One code block has been defined only in the "--extrasmall" block only which in turn results the "--small" block to miss out on them. This does produce incorrect styling when we change the class from "dropbutton--extrasmall" to "dropbutton--small" for the "dropbutton__item".
- The border-radius styling problem reintroduced and not fixed for the dropbutton items.
- The font-weight is still incorrect.

Moving the issue to needs work. I will be looking into these issues.

Fixed the issue by modifying the twig files.

- Added checks to see if the url has a link or no link at all.
- Modified few manual tags to the drupal twig link() filter for better code optimization and automatic handling of the given issue :)

Please review the changes and check if the issue has been fixed or not.

Note: Since drupal twigs link() filter does not allow extra html tags in its text, so I have not changed those links which have other html tags inside the tags.

Thank you @djsagar for reviewing the fix. I have fixed the issue that you mentioned in the recent commit. Along with that I have also fixed the border radius of the dropbuttons not matching their parent wrappers. Attached images of the result.

- Fixed the issue where the dropbutton-wrapper had unecessary box-shadow property causing improper styling.
- Fixed the issue where the border-radius was not matching the parent wrapper for dropbutton_item and dropbutton_toggle.

Moving the issue to Needs Review. Please check if everything works as expected.

Working on it.

@michael.garrido In the reproduction steps you mentioned to use media module. However in the screenshot you have used the file upload field for image. Which one should I follow?
Till now I have not been able to reproduce the error.

Version info of the modules used:
- Drupal 10.2.9
- IEF 3.x (git repo)
- Field Group 3.6
- Paragraphs 1.18

Working on it.

@stephencamilo The issue created title created says about "drupal/entity_embed". Yet the patch changes "drupal/entityqueue" in the composer.json and also added dependency in the info.yml file. Please elaborate the reason for these unrelated changes. If they are related then please explain.

After applying the patch the module does not install correctly as the composer.json file does not have entityqueue as dependency. It is showing the module cannot be installed because of missing dependencies.

Info.yml file change is okay and should be done for correct module declaration and installation. However composer.json file should also have the dependencies mention for it to automatically download them. Having declared the dependencies only in the info.yml exclusively will not work.

@lostcarpark another issue I found with the new navigation of Drupal is the when the variables are dumped on the page (due to devel) the nav bar gets overlapped with the dark variable container. I think its the issue of the navbar.

However because of this the development bar becomes inaccessible when we go to the "theme registry" link :(

@lostcarpark the implementation looks good from my end. All the links are working correctly. Would you like to move the issue to RTBC or wait for further reviews.

The button is looking like this as expected. Also Dark mode has been also checked. Please check in your site @chrisck.

Working on it.

@lostcarpark Thank you for your advice. I will keep that in mind. I tested the module in my site.

- The Development menu only shows when devel module is installed.
- The devel toolbar is not supported (for now). The development menu showed is displaying custom links defined in the deriver.
- Since the devel toolbar is not supported so the devel toolbar settings has no functionality (for now).

It would be nice to have all the links available which are activated in the devel toolbar by default, especially "routes_info" page which is a very useful thing provided by the devel module. Please consider to add them.

Working on it.

Reverted the changes as requested by @ankitv18.

Changed the phpcs.xml.dist file according to suggestion and also to pass the GitLab pipelines.
@chrisfromredfin @jvbrian Please let me know if the changes are satisfactory or not.

Working on it.

@joachim @quietone please review the changes.

@lostcarpark Please review the changes and merge.

Working on it.

@lostcarpark Please review and merge.

Working on it.

Hello @quietone, Please review the changes.

Hello @joachim,
'Defaults to' has been used all across the codebase in similar situations, even in methods present in various Interfaces. I think it will be beneficial to maintain the same format used as it will be easier to understand by others. Plus since we are wanting to do the job of an interface so following the common interface format will not do any harm:)

Hello @joachim, please review the changes.

Hello @joachim, please let me know if the changes are alright.

debrup → changed the visibility of the branch 11.x to hidden.

Hi @joachim,
I've opened the MR, Please have a look:)
Thanks!

Working on it.

debrup → changed the visibility of the branch 11.0.x to active.

debrup → changed the visibility of the branch 11.0.x to hidden.