Linkit shows unpublished media in matcher

Created on 6 November 2024, 10 months ago

Problem/motivation

It would be beneficial to have the option to include unpublished media in a manner similar to how node entities (content) are matched. I consider this a bug since users are able to select unpublished media.

Steps to reproduce

  1. Go to...
  2. Click on...
  3. Observe [describe the expected and actual output]

Proposed resolution

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
🐛 Bug report
Status

Active

Version

7.0

Component

Code

Created by

🇯🇴Jordan Ahmad Khader

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Ahmad Khader
  • 🇮🇳India debrup

    Working on it.

  • 🇺🇸United States mark_fullmer Tucson

    As a maintainer, I would note that if we change the default behavior not to show unpublished media, this would effectively change users' expectations on existing sites. A content editor used to seeing unpublished media items would no longer see them. Is that reasonable? I'm not necessarily saying that we should implement this as an "opt out" feature (i.e., an option to hide unpublished media entities), but if we do this, I think we need to call this out loudly in the release notes and documentation as a behavioral change.

    This thinking might also suggest that the issue would better be characterized as an enhancment/feature, rather than a bug, since the module was originally created at a time when media entities _couldn't_ have a published state, and was not designed to suppress them.

  • First commit to issue fork.
  • Merge request !134Resolve #3485843 "New matcher" → (Open) created by smustgrave
  • Pipeline finished with Canceled
    10 days ago
    Total: 91s
    #575841
  • Pipeline finished with Canceled
    10 days ago
    Total: 310s
    #575842
  • Pipeline finished with Canceled
    10 days ago
    Total: 80s
    #575844
  • 🇺🇸United States smustgrave

    @mark_fullmer would you accept the current approach in the MR? In the update hook I'm seeing the include_unpublished key to TRUE so existing behavior should be maintained. Any new matchers people add will default to FALSE.

  • Pipeline finished with Success
    10 days ago
    Total: 356s
    #575845
Production build 0.71.5 2024