- Issue created by @chrisfromredfin
- First commit to issue fork.
- First commit to issue fork.
- First commit to issue fork.
- 🇮🇳India debrup
Changed the phpcs.xml.dist file according to suggestion and also to pass the GitLab pipelines.
@chrisfromredfin @jvbrian Please let me know if the changes are satisfactory or not. - 🇮🇳India ankitv18
@debrup your both commits are totally irrelevant. Please do revert those commits.
Phpcs failures needs to be to address separate ~~ objective of this issue to add the phpcs.xml.dist file I think we should also fix the problems with the coding standards in PB in the scope of the issue.I'll take this and do that.If someone thinks that it should be done as a separate issue then I'll revert my changes in the commit that I will push.
- Assigned to utkarsh_33
- Status changed to Needs work
3 months ago 5:23am 9 December 2024 - 🇮🇳India sayan_k_dutta
Fixed the phpcs and phpstan issues.
The pipeline is failing for some tests and eslint errors. Someone please look into it. - Issue was unassigned.
- 🇺🇸United States tim.plunkett Philadelphia
tim.plunkett → changed the visibility of the branch 2.0.x to hidden.
- Merge request !736Issue #3477335: Include phpcs.xml.dist & address standards errors → (Merged) created by tim.plunkett
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3477335-include-phpcs.xml.dist to hidden.
- 🇺🇸United States tim.plunkett Philadelphia
Rebuilt this based on how XB is handling it, with @todos pointing to 📌 Only run linting jobs if the files changed make sense for the job Active
- 🇺🇸United States phenaproxima Massachusetts
This seems like great clean-up and it will help us actually catch bugs. I didn't review the .gitlab-ci.yml changes in depth, to be honest, but I'm not particularly concerned about those anyway. The pipeline looks like it's running, and passing, and that seems right to me. I don't really feel like blocking quality improvements. :)
-
chrisfromredfin →
committed 3f7517a5 on 2.0.x authored by
tim.plunkett →
Issue #3477335 by sayan_k_dutta, tim.plunkett, utkarsh_33, jvbrian,...
-
chrisfromredfin →
committed 3f7517a5 on 2.0.x authored by
tim.plunkett →
-
tim.plunkett →
committed 296550d9 on 2.0.x
Issue #3477335: Follow-up; Update core.phpcs.xml.dist
-
tim.plunkett →
committed 296550d9 on 2.0.x