- Issue created by @lostcarpark
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
prem suthar โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
@debrup
navigation_extra_tools.plugin: this have -6 weight and navigation_extra_tools.db_update: also have same weight so as per the standards we cant use same weight for two links. - ๐ฎ๐ชIreland lostcarpark
Thank you both for looking at this.
@prem suthar, yes there were two menu items with the same weight, but they each have different parents, so I don't believe it's a problem.
I don't think any items with
navigation_extra_tools.help
as their parent should change.I think the only change should be to items with a parent of
navigation_extra_tools.flush.help
. The weights of different levels of menu are independent of each other, but if you want to ensure every item has a unique weight, you could start the weights of the submenu items at -19 instead of -9.Setting back to needs work for now.
- ๐ฎ๐ณIndia debrup
@lostcarpark Please review the changes and merge.
- ๐ฎ๐ชIreland lostcarpark
This looks good to me. @prem suthar would you like to review and set to RTBC if you are happy?
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
I have reviewed the MR ! 15 and its working fine as per the issue definition so i move the issue to RTBC.
- ๐ฎ๐ชIreland lostcarpark
Issue successfully merged, and all pipelines passed.
Automatically closed - issue fixed for 2 weeks with no activity.