- Issue created by @chrisck
- First commit to issue fork.
create MR for button fix.
step followed--
- For example, using the Admin content view (/admin/content)
- Edit the Admin content view (/admin/structure/views/view/content)
- Set Exposed form style to Input required
- Set Use AJAX to Yes
- Save the view
- Navigate to Admin content view (/admin/content)
- Input a value in the Title filter that produces a result, and see the grey background on Operations links
Before
After
- 🇨🇦Canada chrisck BC, Canada
I haven't tested the patch, but looking at the screenshot the CSS doesn't look right. The coloured border is supposed to remain and the grey button background should be removed.
- 🇮🇳India debrup
The button is looking like this as expected. Also Dark mode has been also checked. Please check in your site @chrisck.
- 🇮🇳India djsagar
Reproduced the issue on local and applied MR !525.
For example, using the Admin content view (/admin/content)
Edit the Admin content view (/admin/structure/views/view/content)
Set Exposed form style to Input required
Set Use AJAX to Yes
Save the view
Navigate to Admin content view (/admin/content)Result:-
After MR the issue resolved but.Feedback:
You need to handlebox shadow
property which is coming form
dropbutton-wrapper dropbutton-multiple
for reference:
Moving to need work.
- 🇮🇳India debrup
Thank you @djsagar for reviewing the fix. I have fixed the issue that you mentioned in the recent commit. Along with that I have also fixed the border radius of the dropbuttons not matching their parent wrappers. Attached images of the result.
- Fixed the issue where the dropbutton-wrapper had unecessary box-shadow property causing improper styling.
- Fixed the issue where the border-radius was not matching the parent wrapper for dropbutton_item and dropbutton_toggle.Moving the issue to Needs Review. Please check if everything works as expected.
- 🇮🇳India djsagar
Hi @debrup,
Steps:
For example, using the Admin content view (/admin/content)
Edit the Admin content view (/admin/structure/views/view/content)
Set Exposed form style to Input required
Set Use AJAX to Yes
Save the view
Navigate to Admin content view (/admin/content)Result:-
Issue resolved after Merge Request !525.RTBC++
Thanks!
- 🇨🇦Canada chrisck BC, Canada
This is all looking very good. Sorry, there is one last nit. The "Edit" text font-weight should be 525 or
font-weight: var(--gin-font-weight-semibold);
- 🇨🇭Switzerland saschaeggi Zurich
Pretty sure there must be another way instead of setting everything to
!important
Also the build code has a pipeline error. I'll move this back to needs work for now
- 🇮🇳India debrup
@djsagar Thank you for working on this issue and removing the "!important" from the code as it is not an ideal solution.
I have reviewed the code and it is working as expected. However I found some issues with the code which I will be listing below:- Code has been repeated multiple times. I think it should be avoided for maintaining clean code.
- One code block has been defined only in the "--extrasmall" block only which in turn results the "--small" block to miss out on them. This does produce incorrect styling when we change the class from "dropbutton--extrasmall" to "dropbutton--small" for the "dropbutton__item".
- The border-radius styling problem reintroduced and not fixed for the dropbutton items.
- The font-weight is still incorrect.Moving the issue to needs work. I will be looking into these issues.
- Status changed to RTBC
3 months ago 9:11am 31 December 2024 - 🇮🇳India divyansh.gupta Jaipur
I have reviewed this issue and found the edit button's css as expected according to issue's solution,
Before fix:
After fix:
Thus moving it to RTBC+!!