Dropbutton is grey when input required and AJAX on

Created on 7 October 2024, 6 months ago

Problem/Motivation

The Gin theme dropbutton has a grey background when Exposed form style: Input required and Use AJAX: Yes.

Steps to reproduce

  1. For example, using the Admin content view (/admin/content)
  2. Edit the Admin content view (/admin/structure/views/view/content)
  3. Set Exposed form style to Input required
  4. Set Use AJAX to Yes
  5. Save the view
  6. Navigate to Admin content view (/admin/content)
  7. Input a value in the Title filter that produces a result, and see the grey background on Operations links
🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇨🇦Canada chrisck BC, Canada

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chrisck
  • First commit to issue fork.
  • Merge request !5253479239-button-alignment-fix → (Open) created by Unnamed author
  • create MR for button fix.

    step followed--

    1. For example, using the Admin content view (/admin/content)
    2. Edit the Admin content view (/admin/structure/views/view/content)
    3. Set Exposed form style to Input required
    4. Set Use AJAX to Yes
    5. Save the view
    6. Navigate to Admin content view (/admin/content)
    7. Input a value in the Title filter that produces a result, and see the grey background on Operations links


    Before


    After

  • Pipeline finished with Failed
    5 months ago
    Total: 1132s
    #338224
  • 🇨🇦Canada chrisck BC, Canada

    I haven't tested the patch, but looking at the screenshot the CSS doesn't look right. The coloured border is supposed to remain and the grey button background should be removed.

  • 🇮🇳India debrup

    Working on it.

  • Pipeline finished with Success
    5 months ago
    Total: 198s
    #342125
  • 🇮🇳India debrup

    The button is looking like this as expected. Also Dark mode has been also checked. Please check in your site @chrisck.

  • 🇮🇳India djsagar

    Reproduced the issue on local and applied MR !525.

    For example, using the Admin content view (/admin/content)
    Edit the Admin content view (/admin/structure/views/view/content)
    Set Exposed form style to Input required
    Set Use AJAX to Yes
    Save the view
    Navigate to Admin content view (/admin/content)

    Result:-
    After MR the issue resolved but.

    Feedback:
    You need to handle box shadow property which is coming form

    dropbutton-wrapper dropbutton-multiple

    for reference:

    Moving to need work.

  • Pipeline finished with Success
    5 months ago
    #346637
  • 🇮🇳India debrup

    Thank you @djsagar for reviewing the fix. I have fixed the issue that you mentioned in the recent commit. Along with that I have also fixed the border radius of the dropbuttons not matching their parent wrappers. Attached images of the result.

    - Fixed the issue where the dropbutton-wrapper had unecessary box-shadow property causing improper styling.
    - Fixed the issue where the border-radius was not matching the parent wrapper for dropbutton_item and dropbutton_toggle.

    Moving the issue to Needs Review. Please check if everything works as expected.

  • 🇮🇳India djsagar

    Hi @debrup,

    Steps:
    For example, using the Admin content view (/admin/content)
    Edit the Admin content view (/admin/structure/views/view/content)
    Set Exposed form style to Input required
    Set Use AJAX to Yes
    Save the view
    Navigate to Admin content view (/admin/content)

    Result:-
    Issue resolved after Merge Request !525.

    RTBC++

    Thanks!

  • 🇨🇦Canada chrisck BC, Canada

    This is all looking very good. Sorry, there is one last nit. The "Edit" text font-weight should be 525 or font-weight: var(--gin-font-weight-semibold);

  • 🇨🇦Canada chrisck BC, Canada
  • Pipeline finished with Failed
    5 months ago
    Total: 1341s
    #347371
  • 🇨🇭Switzerland saschaeggi Zurich

    Pretty sure there must be another way instead of setting everything to !important

    Also the build code has a pipeline error. I'll move this back to needs work for now

  • 🇮🇳India djsagar

    Not using !important in code.
    Kindly review!

  • Pipeline finished with Success
    5 months ago
    Total: 333s
    #349291
  • 🇮🇳India debrup

    @djsagar Thank you for working on this issue and removing the "!important" from the code as it is not an ideal solution.
    I have reviewed the code and it is working as expected. However I found some issues with the code which I will be listing below:

    - Code has been repeated multiple times. I think it should be avoided for maintaining clean code.
    - One code block has been defined only in the "--extrasmall" block only which in turn results the "--small" block to miss out on them. This does produce incorrect styling when we change the class from "dropbutton--extrasmall" to "dropbutton--small" for the "dropbutton__item".
    - The border-radius styling problem reintroduced and not fixed for the dropbutton items.
    - The font-weight is still incorrect.

    Moving the issue to needs work. I will be looking into these issues.

  • Pipeline finished with Success
    4 months ago
    Total: 196s
    #350190
  • 🇮🇳India debrup

    I have fixed the above issues. Please review.

  • Status changed to RTBC 3 months ago
  • 🇮🇳India divyansh.gupta Jaipur

    I have reviewed this issue and found the edit button's css as expected according to issue's solution,
    Before fix:

    After fix:

    Thus moving it to RTBC+!!

Production build 0.71.5 2024