Just started a DrupalCMS trial on launch day and came looking for this exact issue. IMO there is way too much empty space in both the grid view and list view. If we are keeping the center alignment design, then here is a good implementation for center alignment tile design: https://docs.helpscout.com/
Suggestions
- Reduce min-width of list items in
.pb-projects-listand.pb-projects-gridfrom 400px to 350px - Shorten, center and increase font sizing of the project descriptions
- Increase font sizing of project title, make the link colour black
- Center the Install button and Installed checkmark
Going to add my +1 here as a very desired feature. It is extremely difficult for developers to git diff the current structure_sync.data.yml file when ordering of the keys change, tid changes, weights and multiple entity types (taxonomy, block, menu) combined.
Thanks @bramdriesen this looks good.
damienmckenna → credited chrisck → .
Attended! Merry Christmas and Happy Holidays everyone.
damienmckenna → credited chrisck → .
Following @greggles suggestion, although I'm not a maintainer, I would be happy to write this up in a new issue and start the process including reaching out via contact form and slack - unless there are any objections?
Menu hover active link
After moving your mouse into the submenu, the parent active link loses its bottom border and thus it's very easy to lose which parent link you're browsing on. As the submenu is megamenu style, it's hard to judge based on the horizontal positioning which parent link you're browsing.
From the screenshot below, one would not be able to decipher that we are on "Solutions" without the red annotated bottom border.
I would like to discuss the current and future approaches to structure content and create layouts in Drupal. Here are a few videos that cover the various ways we used to build Drupal sites:
Layout Paragraphs in Drupal - Murray Woodman (19 mins)
Page building showdown: Paragraphs v Layout builder / DrupalCon Global 2020 (56 mins)
2010: Templates, Display Suite
2012: Panels and Panelizer
2014: Panelizer and Paragraphs
2016: Panels IPE
2017: Panels IPE, Bricks, Paragraphs
2018: Layout Builder and Blocks
2019: Layout Builder and Paragraphs
2021: Layout Builder, Layout Paragraphs, Paragraphs
Note, Gutenberg is not included in the list above. However, the Gutenberg block editor is popular in WordPress. Are there still some use cases for Gutenberg? With so many ways to build a site, and often "locked in" with a given approach, which approach is best and what does the future of Drupal lean towards?
Attended.
This is all looking very good. Sorry, there is one last nit. The "Edit" text font-weight should be 525 or font-weight: var(--gin-font-weight-semibold);
Attended.
Attended.
Just reporting back that the MR !14 is working great for me, but I have nowhere near the number of entities as @vlad.dancer.
I haven't tested the patch, but looking at the screenshot the CSS doesn't look right. The coloured border is supposed to remain and the grey button background should be removed.
Attended.
MR!41 does not apply to the 3.x-dev branch. Needs a re-roll.
Attended.
Attended.
Attended for the first time. Thanks Damien!
Thank you for the clarity @vishal.kadam. We'll wait for @dataweb's response.
Hello @vishal.kadam. I'm a co-maintainer for the ief_popup module. I've since released a new semver 2.2.x dev branch that addresses the points in your project review. Could you please review the ief_popup project again and let me know how we may proceed with the security advisory application? I've been in touch with @dataweb and he has accepted my help in co-maintaining the module and making the changes.
As recommended by an active issue ( https://www.drupal.org/project/inline_entity_form/issues/3407711 📌 Other projects should require drupal/inline_entity_form ^1 || ^3 Active ) we will only require ^1 and ^3 release branches.
"require": {
"drupal/inline_entity_form": "^1 || ^3"
}Committed. Thank you @sime for your contributions.
Patches here need rerolling to the newest 2.2.x-dev release.
chrisck → changed the visibility of the branch ief_popup-3422063/2.x to hidden.
@joseft40 I am not familiar with the layout_paragraphs module. Can you please provide clear steps to reproduce the issue? Including the creation of the Layout Paragraph if needed.
Committed. Thank you @alemadlei.
@dataweb Yes, I'd be happy to help as co-maintainer and follow up with security advisory coverage.
@dataweb I see the application for security advisory coverage closed 11 days ago due to lack of activity. As @gomez_in_the_south mentioned, there were only two minor changes requested to complete the application. I can offer to help maintain the module and continue with the application if you wish.
+1 to the approach that @ahsannazir used, I also prefer modifying the values on the original class, rather than applying them to the span tag. I've reviewed and tested MR !401.
@saschaeggi Sorry I need to adjust the steps to reproduce. In the Content Lock settings page (/admin/config/content/content_lock) if Lock form using JS is enabled, then the Unlock button shows up outside of the More menu and is the last item after the sidebar icon. I've tested this with a new Drupal 10 install.
Patch cannot apply to latest dev. Needs re-roll. Removing we_megamenu tag as per tag guidelines → .
@maxilein Your suggestion may not work for everyone. In our case we are needing flexibility around AND/OR logic around the contextual filter from fields of the current entity.
Patch #17 is working for me too. Thanks.
It seems that a patch for this is not necessary. There is a hook_file_download that we can use:
This hook allows modules to enforce permissions on file downloads whenever Drupal is handling file download, as opposed to the web server bypassing Drupal and returning the file from a public directory. Modules can also provide headers to specify information like the file's name or MIME type.
/**
* Implements hook_file_download().
*/
function hook_file_download($uri) {
$filename = \Drupal::service('file_system')->basename($uri);
$disposition = 'attachment; filename="' . $filename . '"';
return [
'Content-disposition' => $disposition,
];
}Replace the hook in your function with your custom module name.
Sorry for the multiple MRs, I'm trying to get a handle on GitLab and the failing pipeline test. I'm unable to delete the branches that I made.
chrisck → changed the visibility of the branch 3389509-drag-handle-multiple-file-widget to hidden.
chrisck → changed the visibility of the branch 3389509-for-multiple-image to hidden.
The MR needs a rebase or a re-roll. Patch could not apply.
The Select All or None buttons have been extremely useful in our project and we've been using it for some time now with no issues. Is it possible to consider making it part of the chosen module?
I managed to get around this error by doing two things, though I’m not sure which has fixed the issue for me.
- Upgraded
mglaman/drupal-checkto ^1.4 - Upgraded
weitzman/drupal-test-traitsto ^2.1
In “require-dev” of composer.json
Same issue
We first installed Smart Date 3.5.0, and then four weeks ago upgraded to 4.1.0-beta1. We've been keeping up with regular updates.
@TolstoyDoyCom Thanks for your MR in the other issue. I'm confirming the MR fixes my issue, as reported here.
This looks to be a general problem in core and perhaps not specific to views_conditional.
Just reporting that we're seeing the same error in the Status page. Not 100% sure when exactly this happened, but could be due to an update.
Mismatched entity and/or field definitions
The following changes were detected in the entity type and field definitions.Content
The node.field_event_datetime field needs to be updated.
+1 to new D10 release please
Just reporting here that contextual_range_filter does work with Smart Date range field type. Make sure your contextual filters are enabled at /admin/config/content/contextual-range-filter
Configure your smart date range field contextual filter as follows:
When the filter value is NOT available
- Provide default value
- Type: PHP code
if (isset($entity['node'])) {
// Get the date range
$start_date = $entity['node']->field_smartdate_range->value;
$end_date = $entity['node']->field_smartdate_range->end_value;
$range = $start_date . '--' . $end_date;
return $range;
}
For lower limit range only:
if (isset($entity['node'])) {
// Get the date range
$start_date = $entity['node']->field_smartdate->value;
$range = $start_date . '--';
return $range;
}
Hope this helps someone.
@asherry Thanks for spotting this. Sorry I missed this in the original MR. As this issue is closed (fixed) I created a new follow up issue with a new MR and tagged you there.